Skip to content

Clean up RFQ examples: fix typos and remove commented code #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
8ball030 merged 2 commits into from
Feb 1, 2026
Merged

Clean up RFQ examples: fix typos and remove commented code #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8d1a34
Initial plan
Copilot Feb 1, 2026
b610691
fix: remove typos and commented-out code from RFQ examples
Copilot Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions examples/rfqs/00_create_rfq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,26 +86,6 @@ def handle_quote(quotes: List[BestQuoteChannelResultSchema]):
amount=D("1"),
direction=Direction.sell,
),
# LegUnpricedSchema(
# instrument_name="ETH-20260125-3050-P",
# amount=D("1.0"),
# direction=Direction.sell,
# ),
# LegUnpricedSchema(
# instrument_name="ETH-20260125-2900-P",
# amount=D("1.0"),
# direction=Direction.sell,
# ),
# LegUnpricedSchema(
# instrument_name="ETH-20260125-3000-P",
# amount=D("1.0"),
# direction=Direction.buy,
# ),
# LegUnpricedSchema(
# instrument_name="ETH-20260126-2900-P",
# amount=D("1.0"),
# direction=Direction.buy,
# ),
]
asyncio.run(
create_and_execute_rfq(
Expand Down
2 changes: 1 addition & 1 deletion examples/rfqs/01_simple_rfq_quoter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ async def on_quote(self, quotes_list: List[QuoteResultSchema]):
# Here we could proceed to perform some type of hedging or other action based on the filled quote.
if quote.status == Status.expired and quote.rfq_id in self.quotes:
del self.quotes[quote.rfq_id]
self.logger.info(f" ✗ Our quote {quote.quote_id} expired Better luck next time!")
self.logger.info(f" ✗ Our quote {quote.quote_id} expired. Better luck next time!")

async def run(self):
await self.client.connect()
Expand Down
4 changes: 2 additions & 2 deletions examples/rfqs/02_delta_hedged_quoter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ async def calculate_delta_from_quote(
is_error = True
break
leg_delta = ticker.option_pricing.delta * leg.amount
# we are the SELLER of the quote so we are in efffect taking the opposite side of the leg direction
# we are the SELLER of the quote so we are in effect taking the opposite side of the leg direction
# we therefore subtract the delta for buy legs and add for sell legs
if leg.direction == Direction.sell:
total_delta += leg_delta
Expand Down Expand Up @@ -255,7 +255,7 @@ async def on_quote(self, quotes_list: List[QuoteResultSchema]):
async with self.quoting_lock:
if quote.status == Status.expired and quote.rfq_id in self.quotes:
del self.quotes[quote.rfq_id]
self.logger.info(f" ✗ Our quote {quote.quote_id} expired Better luck next time!")
self.logger.info(f" ✗ Our quote {quote.quote_id} expired. Better luck next time!")
elif quote.status == Status.filled and quote.rfq_id in self.quotes:
del self.quotes[quote.rfq_id]
self.logger.info(f" ✓ Our quote {quote.quote_id} was accepted!")
Expand Down