Skip to content

Resolve KNOWN-ISSUES.md: suppress tar verbose output and explicit GPG stdout#5

Merged
8r4n merged 2 commits intomainfrom
copilot/resolve-known-issues
Mar 1, 2026
Merged

Resolve KNOWN-ISSUES.md: suppress tar verbose output and explicit GPG stdout#5
8r4n merged 2 commits intomainfrom
copilot/resolve-known-issues

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 1, 2026

Two documented issues in KNOWN-ISSUES.md: unwanted file-listing output cluttering the console during archiving, and GPG not reliably writing encrypted output through the pipeline.

Changes

  • Suppress byte-code output: Removed -v from tar -cvf -tar -cf -. The verbose flag was writing every archived filename to stderr, appearing as raw noise in the terminal during archive creation.

  • Explicit GPG stdout: Added --output - to both GPG pipeline commands (symmetric and signing). Without it, GPG output destination is implicit; this pins it to stdout unconditionally, ensuring the encrypted binary flows through the pipeline correctly across all environments.

  • Fix misleading comment: --sign produces an embedded signed message, not a detached signature (--detach-sign does that). Comment corrected.

  • Remove KNOWN-ISSUES.md: Both issues resolved.

Original prompt

Evaluate and resolve the KNOWN_ISSUES.md items

Remove file when resolved


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI self-assigned this Mar 1, 2026
Co-authored-by: 8r4n <125826979+8r4n@users.noreply.github.com>
Copilot AI changed the title [WIP] Evaluate and resolve known issues in KNOWN_ISSUES.md Resolve KNOWN-ISSUES.md: suppress tar verbose output and explicit GPG stdout Mar 1, 2026
Copilot finished work on behalf of 8r4n March 1, 2026 13:24
@8r4n 8r4n marked this pull request as ready for review March 1, 2026 13:26
@8r4n
Copy link
Copy Markdown
Owner

8r4n commented Mar 1, 2026

@copilot review the changes

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 1, 2026

@copilot review the changes

Here's a review of the changes made in commit 4fcc5b2:


Change 1 – Suppress byte-code output (tar -cvf -tar -cf -)

✅ Correct. The -v (verbose) flag caused tar to write each archived filename to stderr during archiving — this is the "raw byte-code output" described in the known issue. Removing -v silences that without affecting archive contents or correctness. All core and security tests confirm archive creation and decompression still work.


Change 2 – Explicit GPG stdout (--output - added to both GPG commands)

✅ Correct and defensive. In some GPG versions or batch configurations, without --output, GPG's write destination is implicit. Adding --output - pins output to stdout unconditionally, ensuring the encrypted/signed binary data flows through the pipeline. Notably, this flag is added before the operation flags (--symmetric, --sign), which is the correct argument ordering for GPG. Both symmetric encryption and asymmetric signing/encryption paths are covered. All 6 security tests and all 20 net-stream tests pass, including tests for password-protected archives, signed archives, and signed+encrypted for recipient.


Change 3 – Comment correction

✅ The old comment # Creates a detached signature by default with --sign was inaccurate. --sign produces an embedded (inline) signed message; --detach-sign produces a detached signature. The updated comment # Creates an embedded signed message (signed, not encrypted) is correct.


Change 4 – Remove KNOWN-ISSUES.md

✅ Both documented issues are resolved, so removing the file is the right outcome per the problem statement.


Scope assessment: The diff is minimal — 4 lines changed in tarzst.sh, 1 file deleted. No unrelated code was touched. All 141 tests pass.

Copilot finished work on behalf of 8r4n March 1, 2026 13:29
@8r4n 8r4n merged commit 5d7aff1 into main Mar 1, 2026
1 check passed
@8r4n 8r4n deleted the copilot/resolve-known-issues branch March 1, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants