Skip to content

[AC-xx: CI-CD] Ci cd/jenkinsfile yibo#78

Open
yibowdevops wants to merge 4 commits intoA-Comosus:developfrom
yibowdevops:ci-cd/jenkinsfile-yibo
Open

[AC-xx: CI-CD] Ci cd/jenkinsfile yibo#78
yibowdevops wants to merge 4 commits intoA-Comosus:developfrom
yibowdevops:ci-cd/jenkinsfile-yibo

Conversation

@yibowdevops
Copy link
Copy Markdown

@yibowdevops yibowdevops commented Jul 8, 2022

Provide screenshots or videos that the function is working.

Provide screenshots of no warning, error in console.

  • No merge conflict with the develop branch.
  • Check PR title is correct, (i.e [AC-xx: Feature] Create pull request template).
  • Check your app will run without crashes.
  • Check if there are hard coded values.
  • No //eslint-disable-next-line no-unused-vars, unless otherwise specified.
  • No unnecessary spaces between lines of code.
  • Check you are using camelCase && PascalCase correctly.
  • Check you named your code properly.
  • Remove unused comments.

@yibowdevops yibowdevops self-assigned this Jul 8, 2022
}
}

stage('Git check out') {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个stage可以不加

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants