Conversation
|
Forget to add reviewer |
|
Are you sure you have checked the checklist properly? |
|
Also, you need to make sure the tests pass on CI as well |
|
Is ac-120 in jira? |
turnkevin
changed the title
Yes I have already edit the PR |
I create ac-113 as a replacement. |
Yes, I think I pass CI. |
| cy.get('[data-testid="register"]').click(); | ||
| cy.get('#displayName').type('KevinLu'); | ||
| cy.get('[data-testid="continue-btn"]').click(); | ||
| cy.get(':nth-child(2) > .css-13qzv8t').click(); |
There was a problem hiding this comment.
need to test this with data-test-id
There was a problem hiding this comment.
The category(cy.get(':nth-child(2) > .css-13qzv8t').click(), ) seems like not a button, how can I click it? I changed the display-name already.
cypress/support/commands.ts
Outdated
| cy.visit('http://localhost:3000/sign-up'); | ||
| cy.get('form').within(() => { | ||
| const randomStr = (Math.random() + 1).toString(36).substring(7); | ||
| cy.get('#username').type(`KevinLu${randomStr}`); |
There was a problem hiding this comment.
Should this be using username instead?
There was a problem hiding this comment.
I changed #username to id=username like you did in login test
2 participants
Provide screenshots or videos that the function is working.
Provide screenshots of no warning, error in console.
developbranch.[AC-xx: Feature] Create pull request template).//eslint-disable-next-line no-unused-vars, unless otherwise specified.camelCase && PascalCasecorrectly.