Conversation
CGMossa
force-pushed
the
spec_get
branch
2 times, most recently
from
33d6cc9 to
326b3a0
Compare
Draft
7 tasks
dpastoor
requested changes
Mar 2, 2026
| paths = character(), | ||
| glob = character(), | ||
| progress = FALSE, | ||
| parallel = TRUE |
Member
There was a problem hiding this comment.
i don't like operator overloading in general - its confusing/ambiguous as to what to pass, i also think in general users shouldn't need to think about this that often. It is important that its tuneable, but its an edge case that a user should think about it. Similar to data table threads or vroom number of cpus.
eg
Controlling Threads: Set the environment variable VROOM_THREADS before calling vroom() to limit parallel usage (e.g.Sys.setenv(VROOM_THREADS = 2)).
Backend Usage: The readr 2.0+ package uses vroom as a backend, which respects the VROOM_THREADS setting.
| dvs_get <- function( | ||
| paths = character(), | ||
| glob = character(), | ||
| progress = FALSE, |
Member
There was a problem hiding this comment.
why is this not part of the shell spec? will this not be a bit more complicated to implement if this is happening in rust land where its harder?? to tick a progress bar?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.