Open
Conversation
Keats
requested changes
Mar 4, 2026
components/config/src/nonmem.rs
Outdated
| suffix.split('_').collect() | ||
| }; | ||
|
|
||
| Some((version_number, suffix_parts)) |
Collaborator
There was a problem hiding this comment.
can you add some docstring to explain what the suffixes are? I can see it from the tests but it would be nice to be in the docs
components/config/src/nonmem.rs
Outdated
| match (parse_nonmem_version_name(a), parse_nonmem_version_name(b)) { | ||
| (Some((a_num, a_suffix)), Some((b_num, b_suffix))) => b_num | ||
| .cmp(&a_num) | ||
| .then_with(|| a_suffix.cmp(&b_suffix)) |
Collaborator
There was a problem hiding this comment.
Does it make sense to compare anything other than version number? If you have nm73 and nm73gf they are not the same? what does the ordering mean there?
Collaborator
Author
There was a problem hiding this comment.
Yeah I think you're right we can just ignore the suffix entirely. parse the version number then lexical for ties. The suffixes just denoted how the fortran was compiled.
| job_id_str | ||
| .parse() | ||
| .map_err(|e| anyhow!("Failed to parse job ID '{job_id_str}': {e}"))? | ||
| } |
Collaborator
There was a problem hiding this comment.
this block needs some comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.