Conversation
mduncans
reviewed
Jan 21, 2026
R/validate_input_args.R
Outdated
| paste( | ||
| "The output file must be a .docx file, not:", | ||
| tools::file_ext(docx_out) | ||
| if (!is.null(docx_out)) { |
Collaborator
There was a problem hiding this comment.
should this happen before we validate docx_in? if docx in and out are the same (and docx_out is not NULL) then it doesn't matter what extensions?
Collaborator
Author
There was a problem hiding this comment.
Fixed validation pathway now
- check if i/o docx are same - validate input - validate output
mduncans
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fixes
docx_out = NULLforbuild_report()was failing withinvalidate_input_args().Before:
Screen.Recording.2026-01-20.at.3.07.37.PM.mov
After:
Screen.Recording.2026-01-20.at.4.25.52.PM.mov
.rdswere not being processed correctly byadd_tables().Before:
Screen.Recording.2026-01-20.at.4.39.56.PM.mov
After:
Screen.Recording.2026-01-20.at.4.34.34.PM.mov