Merged
Conversation
Member
Author
|
Test run on linux OS, where the lockfile was mutated to point to dplyr 1.1.3 when the available version is 1.1.4. PPM supports the archive at the linux binary end point to support them as complete CRAN-like repos, but serves sources in the Archive. NOTE: The package kind is determined at resolution by looking at the package's available in the binary repository db. Since it is listed, it gets labeled as source, even though it is truly installed as binary. |
Member
Author
|
Similar on mac, we see it trying to fetch |
Collaborator
Can we fix it? |
Member
Author
|
There's a couple reasons I would be fine leaving it:
To me, this case is small enough having the discrepency would be fine, but if we want to take the jump and start to report on a sync what the true source type is for all packages, I can include that in the PR (i.e. we assume local and URL are source, and return it as source, even if we do find a binary at sync time) |
Keats
reviewed
Feb 18, 2026
src/sync/sources/repositories.rs
Outdated
| } | ||
| } | ||
|
|
||
| // 3. Download binary from archive |
Collaborator
There was a problem hiding this comment.
should we try binary from archive before source?
Member
i'm confused on this ordering of it attempting the src first, then "falling back" to the binary archive. eg I'd basically expect the flow to be binary --> binary archive --> src --> src archive for the sequence of lookups |
Member
Author
@rzofchak-a2ai and I talked about it before implementing and thought we should defer to what is "available" before digging into the archive, but also see wanting the speed benefit of the archive. Fortunately, the case where we have both a valid archived binary and a valid non-archived source is quite low, so shouldn't matter very much. I'm also using the |
dpastoor
reviewed
Feb 23, 2026
| &paths, | ||
| "testpkg", | ||
| &PackageType::Binary, | ||
| false, |
Member
There was a problem hiding this comment.
i'm thinking this might be better as a struct for readability - reading this code trying to map what each oft hargs are gets tough. A struct is a little more boilerplate but is clear whats there, and even reading the tests could tell what falues are permuting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to improve performance,
rvwill respect binary archive end points.In standard CRAN-like repositories, archived packages are only kept as source in the following structure:
This PR expands this concept for repositories that wish to expand the binary availability by adding the Archive structure to each binary end point