-
Notifications
You must be signed in to change notification settings - Fork 5
Refactor: cleanup comments and add docstrings #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anshuman444
wants to merge
1
commit into
ABarpanda:main
Choose a base branch
from
anshuman444:refactor/cleanup-and-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -6,56 +6,83 @@ | |||||
| with open("story.json", 'r') as file: | ||||||
| image_texts = json.load(file) | ||||||
|
|
||||||
| # Iterate through keys to get image paths | ||||||
| image_paths: List[str] = list(image_texts.keys()) | ||||||
| # print(image_texts) | ||||||
|
|
||||||
| # Initialize the main window for the application | ||||||
| root = tk.Tk() | ||||||
| root.title("Image Slideshow with Text") | ||||||
|
|
||||||
| # Label widget to display the image | ||||||
| img_label = tk.Label(root) | ||||||
| img_label.pack() | ||||||
|
|
||||||
| # Label widget to display the text, with wrapping | ||||||
| text_label = tk.Label(root, text="", font=("Arial", 14), wraplength=600) | ||||||
| text_label.pack(pady=10) | ||||||
|
|
||||||
| idx: int = 0 | ||||||
| paused: bool = False | ||||||
|
|
||||||
| def update_image() -> None: | ||||||
| """ | ||||||
| Updates the displayed image and text based on the current index. | ||||||
| Schedules the next update unless paused. | ||||||
| """ | ||||||
| global idx, paused | ||||||
| # If paused, do not update the image | ||||||
| if paused: | ||||||
| return | ||||||
|
|
||||||
| # Retrieve current image path and text | ||||||
| img_path = image_paths[idx] | ||||||
| text = image_texts[img_path] | ||||||
|
|
||||||
| # Open and resize the image for display | ||||||
| img = Image.open(img_path) | ||||||
| img = img.resize((600, 400)) | ||||||
| img = ImageTk.PhotoImage(img) | ||||||
|
|
||||||
| # Update the labels | ||||||
| img_label.config(image=img) | ||||||
| img_label.image = img | ||||||
| img_label.image = img # Keep a reference to prevent garbage collection | ||||||
| text_label.config(text=text) | ||||||
|
|
||||||
| # Move to the next index (looping back to 0 if at end) | ||||||
| idx = (idx + 1) % len(image_texts) | ||||||
|
|
||||||
| # Schedule this function to run again after 5000ms (5 seconds) | ||||||
| root.after(5000, update_image) | ||||||
|
|
||||||
| def toggle_pause() -> None: | ||||||
| """ | ||||||
| Toggles the pause state of the slideshow. | ||||||
| """ | ||||||
| global paused | ||||||
| paused = not paused | ||||||
| # If unpausing, immediately update to resume the cycle | ||||||
| if not paused: | ||||||
| update_image() | ||||||
|
|
||||||
| def next_image() -> None: | ||||||
| """ | ||||||
| advances to the next image in the slideshow. | ||||||
|
||||||
| advances to the next image in the slideshow. | |
| Advances to the next image in the slideshow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.