-
Notifications
You must be signed in to change notification settings - Fork 1
master Scheduled Build-CI Fix
#63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dougiesquire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CodeGat. oasis3_mct_version_esm1p5 can now be removed from ./build-ci/data/standard.json, but otherwise LGTM
c98a9d7 to
ae9dfd2
Compare
…e data pair scheduled_ref
dougiesquire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the current exclusion is actually in the wrong place. We want:
master: exclude.github/build-ci/manifests/scheduled/gcc_mom_access-esm1.6.spack.yaml.j2access-esm1.5: exclude.github/build-ci/manifests/scheduled/gcc_mom_access-esm1.5.spack.yaml.j2
dougiesquire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also looks like the version of oasis3-mct that we use in access-esm1.5 doesn't build with oneapi. Let's exclude:
access-esm1.5: exclude.github/build-ci/manifests/scheduled/oneapi_mom_access-esm1.5.spack.yaml.j2
dougiesquire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving now because I'm so confident we're there.
Test of the scheduled workflow is running here: https://github.com/ACCESS-NRI/MOM5/actions/runs/16870417116
Background
In order to get the
{{ scheduled_ref }}for the manifests, we need togit rev-parsetheHEADof the branch. We had updated the checkout logic to checkoutaccess-esm1.5instead ofmasterso we could get thatHEADin theaccess-esm1.5case, but the manifests themselves weren't in that branch! So we should move the manifests that deal with scheduled checks out of themasterbranch, into the branch that they'll be used.So now, instead of the old directory structure, which namespaced scheduled tests by branch name on
master, we don't have to separate them, as they are on their own branch. Instead, we have:On master: .github/ ├── build-ci/ │ ├── data/ │ │ └── standard.json │ └── manifests/ │ ├── pr/ │ │ └── ... │ └── scheduled/ │ ├── gcc_mom_access-esm1.6.spack.yaml.j2 │ └── ... └── workflows/ ├── ci.yml └── scheduled.yml On access-esm1.5: .github/ ├── build-ci/ │ ├── data/ │ │ └── standard.json │ └── manifests/ │ ├── pr/ │ │ └── ... │ └── scheduled/ │ ├── gcc_mom_access-esm1.5.spack.yaml.j2 │ ├── intel_mom_access-esm1.5.spack.yaml.j2 │ └── oneapi_mom_access-esm1.5.spack.yaml.j2 └── workflows/ └── ci.ymlSo this PR removes the namespacing of scheduled tests, and deletes the
access-esm1.5-specific ones (to be moved to theaccess-esm1.5branch).The PR
scheduled/mastermanifests underscheduledscheduled/access-esm1.5(move toaccess-esm1.5branch)HEADinstead oforigin/BRANCH