Conversation
micaeljtoliveira
left a comment
micaeljtoliveira
left a comment
There was a problem hiding this comment.
Looks like you are completely replacing the existing WW3 CMake build system. Are you planning to contribute this back upstream?
dougiesquire
left a comment
dougiesquire
left a comment
There was a problem hiding this comment.
Thanks @anton-seaice! Nothing much to add on @micaeljtoliveira's comments.
I do think the commit history should refer back to COSIMA/access-om3/WW3 somewhere to maintain provenance and credit back to @micaeljtoliveira's original work.
No plans at this point - the upstream CMake was hard to understand and stylistically quite different from how we write them. I couldn't see how we would reconcile build flags or switches with the upstream version. We could make a totally seperate CMakeLists file to make this clearer? |
No, it's okay to leave it like this. Just wanted to understand the reasoning. |
|
I think I addressed all the comments, - this can be rereviewed. new builds ACCESS-NRI/ACCESS-OM3#35 (comment) |
dougiesquire
left a comment
dougiesquire
left a comment
There was a problem hiding this comment.
Good with me. I still think this is a good idea, but I'll leave it up to you.
Co-authored-by: Micael Oliveira <micael.Oliveira@anu.edu.au>
This adds a CMake build for ACCESS3 models. By default, it builds some WW3 utilities and the shell test program. If WW3_ACCESS3 is ON, it builds a library for access3 models (and using the https://github.com/ACCESS-NRI/access3-share dependencies) * This was based on the https://github.com/cOSIMA/access-om3 CMake Co-authored-by: Micael Oliveira <micael.Oliveira@anu.edu.au>
This adds a CMake build for ACCESS3 models. By default, it builds some WW3 utilities and the shell test program. If WW3_ACCESS3 is ON, it builds a library for access3 models (and using the https://github.com/ACCESS-NRI/access3-share dependencies) * This was based on the https://github.com/cOSIMA/access-om3 CMake Co-authored-by: Micael Oliveira <micael.Oliveira@anu.edu.au>
3 participants
This changes the CMake build in WW3 to support ACCESS-OM3. It includes the patches from https://github.com/COSIMA/access-om3/tree/main/WW3/patches.
There is a library build and a standalone build which adds the ww3_shel executable
All the WW3 forks are a mess, so i just overwrote the CMakeLists.txt file. We could change it in the future to have a seperate CMakeLists.txt file for access if needed.
general FYI @chrisb13 @ezhilsabareesh8 @dougiesquire
Closes #1