Spack V1 Migration Feature: Reserved Spack Definitions#332
Merged
CodeGat merged 21 commits intospack-v1-migrationfrom Jan 16, 2026
Merged
Spack V1 Migration Feature: Reserved Spack Definitions#332CodeGat merged 21 commits intospack-v1-migrationfrom
CodeGat merged 21 commits intospack-v1-migrationfrom
Conversation
d9694d0 to
857bbd2
Compare
Member
Author
|
This looks about ready to go! |
This was referenced Dec 4, 2025
Member
aidanheerdegen
left a comment
There was a problem hiding this comment.
An initial pass, but might need a peer-review to ask some more questions.
3da2716 to
a685e21
Compare
e871355 to
db7e3db
Compare
Member
Author
|
After the rebase onto |
984b2d3 to
2d1bac4
Compare
6 tasks
…only deployment-[name|version]
…remove --keep-root-spec-intact flag
Update reserved defs getter return value, remove case statement, revert autoformatter
1a53fa3 to
5a1c869
Compare
…om release projection logic
Member
Author
|
After the rebase, I note it has passed testing: ACCESS-NRI/ACCESS-TEST#60 (comment) |
CodeGat
commented
Jan 15, 2026
b81b2df to
6a99772
Compare
644da23 to
16fc6c6
Compare
7aebf30 to
5a1c7e3
Compare
aidanheerdegen
approved these changes
Jan 16, 2026
Member
aidanheerdegen
left a comment
There was a problem hiding this comment.
LGTM, thanks! Nice work.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #330
Will be merged into #326
Background
Root specs are very meaningful in our infrastructure. This comes with a few downsides, mostly in the cases where we have multiple specs in the speclist, or regular users want to use prerelease manifests in their own instances but can't due to prerelease-specific modifications of the root spec.
In this PR, we move away from important information being in the
.spack.specs[0]field, and instead use reserved, dummy definitions at the top of the file:This means that speclists can be free from infra-specific information, and they are open to future modification.
The PR
get-spack-root-specaction to the more aptget-spack-manifestdeployment-{name|version}outputs, equivalent to.spack.definitions[]._{name|version}[0]fields.get-spack-root-specaction toget-spack-manifest{name}/prX-Y/{hash:7}{name}/prX-Y/DEMARCATOR, where the DEMARCATOR is the defined projection. For example,{name}/prX-Y/{variants.x}x{variants.y}_version. It is not yet allowed in Releases.Testing
Testing Details in this collapsed section
Unit Tests
Done via
pytest, all pass.MDR Testing
Done for regular MDRs in ACCESS-NRI/ACCESS-TEST#60
Prerelease (Draft)
Success, see https://github.com/ACCESS-NRI/ACCESS-TEST/actions/runs/19916256065
Prerelease (Ready For Review)
Success, see https://github.com/ACCESS-NRI/ACCESS-TEST/actions/runs/20013811438
Prerelease (
!redeploy)Expected failure, since the schema version updates are not yet on the
mainbranch (since comment triggers are technically in the context of themainbranch). But, the only points of difference (The status setting in https://github.com/ACCESS-NRI/ACCESS-TEST/actions/runs/20014778511/job/57390074093 and https://github.com/ACCESS-NRI/ACCESS-TEST/actions/runs/20014778511/job/57390091047) succeeded as expected.Software Deployment Repository Testing
Done for Software Deployment Repostiories in ACCESS-NRI/system-tools#19
Prerelease (Draft)
Succeeded, see https://github.com/ACCESS-NRI/system-tools/actions/runs/20151461268?pr=19
Prerelease (Ready For Review)
Succeeded. see https://github.com/ACCESS-NRI/system-tools/actions/runs/20217336546?pr=19
Prerelease (
!redeploy)Expected failure, since the schema version updates are not yet on the
mainbranch (since comment triggers are technically in the context of themainbranch). But, the only points of difference (The status setting in https://github.com/ACCESS-NRI/system-tools/actions/runs/20217823516/job/58033899157 and https://github.com/ACCESS-NRI/system-tools/actions/runs/20217823516/job/58033912451) succeeded as expected.