Conversation
Member
Author
|
The CI failure is a style check on a package I didn't touch. I feel no responsibility to fix it. |
CodeGat
approved these changes
Dec 10, 2025
Member
CodeGat
left a comment
There was a problem hiding this comment.
Looks good. I also validated that go@1.22: exists in spack v0.22, which it does
Member
Author
|
I'm just running an install test on |
Member
Author
|
Worked fine |
Collaborator
|
Hi @aidanheerdegen & @CodeGat , Please replace the Spack upstream PR number with this PR number in the cherry-picked commits' subject line. Also, please add the original Spack upstream commit hash in the commit message. |
aidanheerdegen
pushed a commit
that referenced
this pull request
Dec 14, 2025
* Cherry-picked upstream commit 5e363bd
aidanheerdegen
pushed a commit
that referenced
this pull request
Dec 14, 2025
* Cherry-picked upstream commit 32dfb52
aidanheerdegen
pushed a commit
that referenced
this pull request
Dec 15, 2025
* cherry-picked 32dfb52
aidanheerdegen
pushed a commit
that referenced
this pull request
Dec 15, 2025
* cherry picked d4a7582
Merged
aidanheerdegen
pushed a commit
that referenced
this pull request
Dec 15, 2025
* cherry-picked 32dfb52
aidanheerdegen
pushed a commit
that referenced
this pull request
Dec 15, 2025
* cherry picked d4a7582
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick commits to update
ghspack package so a new version can be deployed for this ACCESS-NRI/system-tools#17Only two versions were cherry-picked, as there was a change to a
gobuilder, that was later reverted. Looked messy, so avoided that as it wasn't required for this use case.Looked into updating some of the other SPRs referenced in the PR above, but
ncduhad no updates,opensshhad already been updated, andpinentryseemed kinda niche, so didn't do anything with that.