-
Notifications
You must be signed in to change notification settings - Fork 0
Conda packaging #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conda packaging #26
Conversation
jo-basevi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Just a couple insignificant questions - so feel free to resolve
|
@jo-basevi I also forgot to add a job for a version sanity check. Would you mind having a look at the PR now in its final state? |
34296e4 to
29cbca9
Compare
jo-basevi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - no major comments.
I wonder if it would be useful using the semver command line tool, or similar, for parsing and comparing versions? Could have logic checking if a tag equals one of semver --increment "major" "$new_tag_name" or semver --increment "minor" "$new_tag_name", etc. I think (?) semver $new_tag_name only returns zero if it's a valid version too.
29cbca9 to
00fb6dd
Compare
…release. Added cleanup step for release tags
194d528 to
814ad68
Compare
ce133c8 to
96e502e
Compare
jo-basevi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think the changes looks good to me. I just have another small comment
jo-basevi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @atteggiani, looks good to me!
|
Thank you @jo-basevi for reviewing! |
Added resources for
condapackaging.The
umfile_utilspackage will be released to the accessnri anaconda channel and will be installable with:This PR includes CI/CD framework to automatically verify, build and upload the
umfile_utilspackage.