Conversation
|
Can not add any reviewers @uandrae @mfroelund |
|
Fixed! |
|
|
||
| on: | ||
| release: | ||
| types: [created] |
There was a problem hiding this comment.
Not completely sure what the "created" type actually trigger on. Will it trigger also for drafting a new release? Then maybe using published is better ?
There was a problem hiding this comment.
Good point. I never draft my releases, so it works the same way. Could be changed.
mfroelund
left a comment
mfroelund
left a comment
There was a problem hiding this comment.
Looks good, I just have one question/comment. Also have you tested it?
This is not fully tested, but it's used in https://github.com/metno/pysurfex/actions/runs/15667240243 (copied from there, and I have tested build) However, as this PR is at the moment it will not work as we need to make a decision on where to upload the wheels (no secret in repo and I don't want to use my pypi token for this) |
3 participants
Could also be changed to a private REPO
Anyway we would need to enable a local package repo or have a token for the pypi repo.
It would be convenient to have built packages as it is needed for other packages using grib2sqite as a dependency from pypi