Correctly use prices and features in battery environment#72
Merged
ADGEfficiency merged 8 commits intomainfrom May 10, 2025
Merged
Correctly use prices and features in battery environment#72ADGEfficiency merged 8 commits intomainfrom
ADGEfficiency merged 8 commits intomainfrom
Conversation
- Added proper feature handling in battery environment - Updated observation space to include feature dimensions - Improved feature initialization in make_env - Added test for observation with features - Fixed reward calculation logic using electricity prices - Updated existing tests to use both prices and features Closes #69 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
ADGEfficiency
changed the title
- Fix 'shape' attribute access by using isinstance() instead of hasattr() - Change observation_space to use np.float64 for consistency - Fix feature_obs creation to handle arrays properly - Update _get_obs() to return np.float64 arrays 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Update Battery class to properly handle features array - Add proper typing for battery parameters - Increase test coverage requirement from 50% to 90% - Fix test_make_env to use correct feature format 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Reduce training steps and evaluation episodes - Simplify network architecture - Reduce data size and feature dimensions - Reduce number of test cases 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
This PR addresses issue #69 by making the following improvements:
Features
make_envfunction to create features from prices when none are providedFixes
Tests