Skip to content

fix(batch): drain finalize after fail-fast; add tests#11

Merged
AEliu merged 3 commits intomasterfrom
fix/fail-fast-finalize-drain
Mar 19, 2026
Merged

fix(batch): drain finalize after fail-fast; add tests#11
AEliu merged 3 commits intomasterfrom
fix/fail-fast-finalize-drain

Conversation

@AEliu
Copy link
Copy Markdown
Owner

@AEliu AEliu commented Mar 19, 2026

Summary

  • fix(batch): allow queued finalize to drain after fail-fast on finalize in pipeline mode
  • test(batch): add coverage for fail-fast on finalize verifying no new downloads launch while queued finalize completes, and in-flight download's prepared finalize still succeeds

Details

  • manager.py: break only when stop_batch is set AND both slots are idle AND staged_queue is empty, so finalize draining can complete
  • tests: deterministic ordering via Events to avoid flakes; no network/filesystem

Test plan

  • uv run ruff check .
  • uv run mypy --hide-error-context --pretty --strict src/artx
  • uv run pytest -q

🤖 Generated with Claude Code

AEliu and others added 3 commits March 19, 2026 11:47
test(batch): add pipeline fail-fast finalize tests covering queued finalize and in-flight download finalize

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ommand

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ng variance

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@AEliu AEliu merged commit 3f2fdf1 into master Mar 19, 2026
2 checks passed
@AEliu AEliu deleted the fix/fail-fast-finalize-drain branch March 19, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant