Skip to content

Remove noop spmd_mode check, correct type annotations in attention flax #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Remove noop spmd_mode check, correct type annotations in attention flax #170

wants to merge 2 commits into from

Conversation

coolkp
Copy link
Collaborator

@coolkp coolkp commented May 1, 2025

Changes:

  1. attention_flax.py
    • fix type annotations
    • change AttentionOp's scale param type to float, since it is passed as float to subsequent DotProductAttention calls
  2. train_utils.py

@coolkp
Remove noop spmd_mode check, correct type annotations in attention flax
ff35c30 
Signed-off-by: Kunjan patel <kunjanp@google.com>
@coolkp coolkp requested a review from entrpn May 1, 2025 18:02
@coolkp
Fix type annotation mismatches in pil_utils.py and outputs.py
4005a8e 
Signed-off-by: Kunjan patel <kunjanp@google.com>
@coolkp coolkp marked this pull request as draft May 1, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@entrpn entrpn entrpn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coolkp @entrpn