Skip to content

Unset metadata prefetch memory limits. #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Unset metadata prefetch memory limits. #516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/xpk/core/storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
"gke-gcsfuse/cpu-limit": "0",
"gke-gcsfuse/memory-limit": "0",
"gke-gcsfuse/ephemeral-storage-limit": "0",
"gke-gcsfuse/metadata-prefetch-memory-limit": "0",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only required when argument "prefetch_metadata" is provided, what would be the best place to add this check?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would have to add the prefetch_metadata flag to Storage CRD and change this const to a function that would take the list of storages and check if any of them has the flag set.

I'm not against adding it as default here, as it probably doesn't do anything if gcsfuseMetadataPrefetchOnMount is not set (correct me if I'm wrong).

In either case I would also consider removing gke-gcsfuse/metadata-prefetch-cpu-limit and gke-gcsfuse/metadata-prefetch-ephemeral-storage-limit.

}
PARALLELSTORE_ANNOTATIONS = {
"gke-parallelstore/volumes": "true",
Expand Down