Skip to content

fix: read indices_test.pkl in get_shadow_model#443

Open
shamykyzer wants to merge 1 commit intomainfrom
fix/442-get-shadow-model
Open

fix: read indices_test.pkl in get_shadow_model#443
shamykyzer wants to merge 1 commit intomainfrom
fix/442-get-shadow-model

Conversation

@shamykyzer
Copy link
Copy Markdown
Contributor

@shamykyzer shamykyzer commented Apr 15, 2026

Fixes #442

get_shadow_model in sacroml/attacks/utils.py was opening indices_train.pkl twice, so the returned indices_test actually contained the train indices.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.51%. Comparing base (42041fd) to head (4054a31).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #443   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files          23       23           
  Lines        2687     2687           
=======================================
  Hits         2674     2674           
  Misses         13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shamykyzer shamykyzer self-assigned this Apr 15, 2026
@shamykyzer shamykyzer requested a review from rpreen April 15, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get_shadow_model loads indices_train.pkl twice instead of indices_test.pkl

1 participant