Merged
Conversation
Co-authored-by: vainiovesa <vainiov14@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a “mute display” mode so backend/AI text is not forwarded to the G1 glasses (except system messages), improves recording UI state handling, and updates iOS project configuration to support building on iOS.
Changes:
- Add mute/unmute display toggle and prevent display updates when muted.
- Add widget tests verifying muted vs unmuted display behavior (via improved BLE transcription mocks).
- Update BLE connection flow and iOS project files (Pods/workspace/plist/AppDelegate) for iOS builds.
Reviewed changes
Copilot reviewed 10 out of 13 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| test/widget_test.dart | Adds UI + mute-display behavior tests using an injected test WebSocket service. |
| test/ble_mock/g1_manager_mock.dart | Enhances transcription mock to record displayText/displayLines calls for assertions. |
| pubspec.lock | Updates several transitive package versions/hashes. |
| packages/even_realities_g1/lib/src/bluetooth/g1_manager.dart | Adjusts scanning/connection flow (connect when both glasses discovered) and adapter/device checks. |
| packages/even_realities_g1/lib/src/bluetooth/g1_glass.dart | Avoids Android-only MTU/priority calls on non-Android platforms. |
| lib/services/websocket_service.dart | Changes disposal strategy to avoid async disconnect() during dispose. |
| lib/screens/landing_screen.dart | Implements mute-display behavior and adds a “recording busy” lock for UI actions. |
| ios/Runner/Info.plist | Adds missing permission descriptions and scene manifest entries. |
| ios/Runner/AppDelegate.swift | Updates plugin registration approach for iOS engine initialization. |
| ios/Runner.xcworkspace/contents.xcworkspacedata | Adds Pods project reference into the workspace. |
| ios/Runner.xcodeproj/project.pbxproj | Adds CocoaPods build phases/config refs and updates signing/bundle settings. |
| ios/Podfile.lock | Adds CocoaPods lockfile for iOS dependencies. |
| ios/Flutter/AppFrameworkInfo.plist | Removes MinimumOSVersion key from Flutter framework plist. |
Files not reviewed (1)
- ios/Runner.xcworkspace/contents.xcworkspacedata: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature to mute display so that no text is sent to the glasses except system messages e.g. "recording started / stopped" + tests. Includes also files and edits for building for IOS platform