Conversation
Contributor
审阅者指南通过引入状态变量、将机器人动机格式化提取到具有副作用的辅助方法中，并重构主格式化器以使用该方法而不是内联逻辑，实现了机器人动机消息的去重。 聊天日志格式化中机器人动机去重的序列图sequenceDiagram
participant ChatHistoryFormatter
participant Stimulus
participant log_lines
participant sender_uid
ChatHistoryFormatter->>Stimulus: Get sender_id and motivation
ChatHistoryFormatter->>ChatHistoryFormatter: _format_and_track_motivation(stimulus, sender_uid)
alt sender_uid == "U0" and motivation present
alt motivation != last_displayed_bot_motive
ChatHistoryFormatter->>log_lines: Append formatted motivation
ChatHistoryFormatter->>ChatHistoryFormatter: Update last_displayed_bot_motive
else motivation == last_displayed_bot_motive
ChatHistoryFormatter->>ChatHistoryFormatter: Update last_displayed_bot_motive
end
else sender_uid != "U0" or no motivation
ChatHistoryFormatter->>ChatHistoryFormatter: Reset last_displayed_bot_motive
end
更新后的 ChatHistoryFormatter 动机跟踪的类图classDiagram
class ChatHistoryFormatter {
- last_valid_text_message: str | None
- image_ref_counter: int
- last_displayed_bot_motive: str | None
+ _build_user_maps()
+ _is_unread(stimulus: Stimulus): bool
+ _format_and_track_motivation(stimulus: Stimulus, sender_uid: str): str | None
+ format_chat_log_block(): str
}
ChatHistoryFormatter --> Stimulus
文件级更改
提示和命令与 Sourcery 互动
自定义您的体验访问您的 仪表盘 以：
获取帮助Original review guide in EnglishReviewer's GuideAdds de-duplication of bot motivation messages by introducing a state variable, extracting motivation formatting into a helper method with side effects, and refactoring the main formatter to use it instead of inline logic. Sequence diagram for bot motivation de-duplication in chat log formattingsequenceDiagram
participant ChatHistoryFormatter
participant Stimulus
participant log_lines
participant sender_uid
ChatHistoryFormatter->>Stimulus: Get sender_id and motivation
ChatHistoryFormatter->>ChatHistoryFormatter: _format_and_track_motivation(stimulus, sender_uid)
alt sender_uid == "U0" and motivation present
alt motivation != last_displayed_bot_motive
ChatHistoryFormatter->>log_lines: Append formatted motivation
ChatHistoryFormatter->>ChatHistoryFormatter: Update last_displayed_bot_motive
else motivation == last_displayed_bot_motive
ChatHistoryFormatter->>ChatHistoryFormatter: Update last_displayed_bot_motive
end
else sender_uid != "U0" or no motivation
ChatHistoryFormatter->>ChatHistoryFormatter: Reset last_displayed_bot_motive
end
Class diagram for updated ChatHistoryFormatter motivation trackingclassDiagram
class ChatHistoryFormatter {
- last_valid_text_message: str | None
- image_ref_counter: int
- last_displayed_bot_motive: str | None
+ _build_user_maps()
+ _is_unread(stimulus: Stimulus): bool
+ _format_and_track_motivation(stimulus: Stimulus, sender_uid: str): str | None
+ format_chat_log_block(): str
}
ChatHistoryFormatter --> Stimulus
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Summary of Changes
Hello @Dax233, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
此拉取请求旨在优化聊天历史记录的格式化，特别是针对机器人动机的显示。通过引入一个机制来追踪并去重连续的机器人动机，它确保了聊天日志的清晰度，避免了重复信息的冗余显示。
Highlights
- 动机追踪: 引入了
last_displayed_bot_motive实例变量，用于在ChatHistoryFormatter中追踪上一个显示的机器人动机。 - 新辅助方法: 创建了一个新的私有方法
_format_and_track_motivation，封装了机器人动机的格式化和去重逻辑。 - 代码重构: 重构了
format_chat_log_block方法，以利用新的辅助函数来处理机器人动机，从而简化了主格式化逻辑。
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
聊天记录长， 动机重复惹人烦， 去重显简洁。
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
嘿 @Dax233 - 我已经审查了你的更改，它们看起来很棒！
AI 代理提示
请解决此代码审查中的评论：
## 个人评论
### 评论 1
<location> `src/common/focus_chat_history_builder/chat_history_formatter.py:55` </location>
<code_context>
self.last_valid_text_message: str | None = None
self.image_ref_counter = 0
+ # 追踪上一个显示的机器人动机
+ self.last_displayed_bot_motive: str | None = None
+
</code_context>
<issue_to_address>
非英文注释可能会降低非中文使用者的可维护性。
请考虑将注释更新为英文，以确保所有团队成员都能理解和维护代码。
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
# 追踪上一个显示的机器人动机
self.last_displayed_bot_motive: str | None = None
=======
# Track the last displayed bot motive
self.last_displayed_bot_motive: str | None = None
>>>>>>> REPLACE
</suggested_fix>帮助我更有用！请点击每个评论上的 👍 或 👎，我将根据反馈改进您的评论。
Original comment in English
Hey @Dax233 - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `src/common/focus_chat_history_builder/chat_history_formatter.py:55` </location>
<code_context>
self.last_valid_text_message: str | None = None
self.image_ref_counter = 0
+ # 追踪上一个显示的机器人动机
+ self.last_displayed_bot_motive: str | None = None
+
</code_context>
<issue_to_address>
Non-English comments may reduce maintainability for non-Chinese speakers.
Consider updating comments to English to ensure all team members can understand and maintain the code.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
# 追踪上一个显示的机器人动机
self.last_displayed_bot_motive: str | None = None
=======
# Track the last displayed bot motive
self.last_displayed_bot_motive: str | None = None
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sourcery 总结
重构聊天历史记录格式化器，以提取并集中机器人动机的格式化和去重逻辑
增强功能：
last_displayed_bot_motive状态来跟踪并抑制重复的机器人动机_format_and_track_motivation辅助函数中format_chat_log_block中内联的动机处理替换为对新辅助函数的调用Original summary in English
Summary by Sourcery
Refactor chat history formatter to extract and centralize bot motive formatting and deduplication logic
Enhancements: