Open
Conversation
- src/controller.py: AdaptiveController + FixedTimeController migrated from Dev's prototype with str direction interface - src/utils/mock_data.py: shared test fixtures for all PODs (MOCK_VEHICLES, MOCK_QUEUES, MOCK_SIGNAL, MOCK_SNAPSHOT, MOCK_SIM_STATE, config path constants) - configs/adaptive_params.json: complete param set with all 12 keys used by controller rules Unblocks: POD 2 unit tests, POD 3 metrics tests, POD 5 QA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Description
What
Pushes the two remaining POD 0 Week 1 deliverables:
src/controller.py— both controllers, interfaces.md compliantsrc/utils/mock_data.py— shared test fixturesUnblocks
How to use mock_data in your tests
from src.utils.mock_data import MOCK_VEHICLES, MOCK_QUEUES, MOCK_SIGNAL, MOCK_SNAPSHOT
Interface reminder
controller.tick(dt) # call every frame
signal = controller.get_signal(MOCK_QUEUES) # returns 'N','S','E','W'
🎯 Related Issues
🧩 Pod & Component
✨ Changes Made
🧪 Testing Done
Test Coverage:
Test Commands Run:
📸 Screenshots/Demos
📝 Documentation
✅ Checklist
Code Quality:
black src/for formattingpylint src/and addressed issuesTesting:
Integration:
developinto this branchRequirements:
Documentation:
🔄 Breaking Changes
If yes, describe:
🚀 Deployment Notes
👥 Reviewers
@AJ-ing @medhanshgupta2024
Pod Lead Review Required: @[pod-lead-username]
💬 Additional Context
📊 Metrics (Auto-populated by CI)
Code Changes:
Performance Impact:
For Reviewers - Please Check:
Review Turnaround Time: Please review within 24 hours 🙏