⚡ Parallelize Stripe price creation for product variants#49
⚡ Parallelize Stripe price creation for product variants#49
Conversation
Co-authored-by: AJFrio <20246916+AJFrio@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bca45cea16
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Create Stripe prices for each combination | ||
| for (const combo of combinations) { | ||
| await Promise.all(combinations.map(async (combo) => { | ||
| const stripePrice = await this.stripe.createPrice({ |
There was a problem hiding this comment.
Because this now fires all createPrice requests at once, products with many variant combinations can easily exceed Stripe’s API rate limits and fail the whole Promise.all (whereas the previous sequential loop would typically succeed, just slower). This regression appears when variant counts are large enough to trigger throttling. Consider adding a concurrency limit (e.g., a small pool) or a retry/backoff strategy for createPrice calls.
Useful? React with 👍 / 👎.
1 participant
💡 What: Replaced the sequential loop for creating Stripe prices in
ProductStripeService.jswithPromise.allto execute requests concurrently.🎯 Why: Creating prices sequentially for products with multiple variants was causing significant delays. Parallelizing these requests drastically reduces the total operation time.
📊 Measured Improvement:
PR created automatically by Jules for task 18404150179723580484 started by @AJFrio