ci: add root .editorconfig and centralize lint configs under .github/config#355
Open
ci: add root .editorconfig and centralize lint configs under .github/config#355
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
.editorconfigshim so contributor tooling works out of the box..github/config/to make workflows and hooks reference a single location.Description
/.editorconfigto surface formatting rules to editors and IDEs without changing CI logic..github/config/:commitlint.config.cjs,editorconfig,pre-commit-config.yaml,pylintrc,pyproject.toml, andstylelintrc.json./.github/workflows/lint.ymlthat runs Commitlint, ESLint/Stylelint forfrontend, Ruff/Pylint forbackend, pre-commit hooks, and a Gitleaks scan..github/config/(for example--config .github/config/pyproject.tomland--rcfile=.github/config/pylintrc).Testing
nl -ba .editorconfigandnl -ba .github/config/editorconfig, which displayed the expected root shim and preserved centralized copy.git status --short, which showed the new files staged as expected.git add .editorconfig && git commit -m "ci: add root editorconfig for out-of-box editor support", and the commit succeeded.make_prhelper, which completed successfully.Codex Task