Remove Out-commented Code in Erfurt #140
Conversation
Remove commented out code and apply coding standards of Erfurt_Store_Adapter_EfZendDb
|
Tests: |
| $this->ts = new Erfurt_Sparql_EngineDb_TypeSorter($this->query, $this); | ||
|
|
||
| $this->_setOptions(); | ||
|
|
There was a problem hiding this comment.
This method is removed from Line 367
| //$this->projectionVars = array(); | ||
| break; | ||
| case self::typeDescribe: | ||
| break; |
There was a problem hiding this comment.
Remove the breaks for select and ask, such that select, ask and describe result in one common break, (still they should not go to default)
There was a problem hiding this comment.
Ok this is a change request ;-)
| # 'st' => $subjectIs, | ||
| # 'ot' => $objectIs | ||
| #); | ||
|
|
| # 'st' => $subjectIs, | ||
| # 'ot' => $objectIs | ||
| #); | ||
|
|
white-gecko
left a comment
white-gecko
left a comment
There was a problem hiding this comment.
Sorry there was one change request
| //$this->projectionVars = array(); | ||
| break; | ||
| case self::typeDescribe: | ||
| break; |
There was a problem hiding this comment.
Ok this is a change request ;-)
|
Please also run tests for MySQL backend |
shinobu
force-pushed
the
feature/removeOutcommentedCode
branch
from
979de57 to
3d5e8b0
Compare
|
done @white-gecko |
…ommentedCode Conflicts: library/Erfurt/Sparql/Query2.php library/Erfurt/Store/Adapter/Mssql.php library/Erfurt/Syntax/RdfParser/Adapter/RdfXml.php
pfrischmuth
left a comment
pfrischmuth
left a comment
There was a problem hiding this comment.
just want to get this out of my inbox... sorry
3 participants
This Pull Request removes all (or most) of the outcommented code in erfurt.
This Pull Request is based on #138 , which already started removing outcommented code in one file, so this request should be merged after it.