Check Uri for Knowledge Base Creation by shinobu · Pull Request #400 · AKSW/OntoWiki

shinobu · 2016-10-04T22:35:47Z

This fix checks the URI for knowledge base creation for http://

This Pull Request does fix #399

white-gecko

The wording of the error message should be improved. Further it would be good to implement the fix in Erfurt and catch the according exception here.
Please also check at which level OntoWiki is already catching such Exceptions.

white-gecko · 2016-10-14T11:55:12Z

application/controllers/ModelController.php

                return;
+            } else if (!Erfurt_Uri::check($newModelUri)) {
+                $this->_owApp->appendMessage(
+                    new OntoWiki_Message('The given String is no legal URI (http://...)', OntoWiki_Message::ERROR)


The hint "http://…" connotes, that the algorithm already identified the missing protocol part, while there might be other cases for the value not being a valid URI or IRI.

white-gecko · 2016-10-14T11:55:36Z

application/controllers/ModelController.php

                return;
+            } else if (!Erfurt_Uri::check($newModelUri)) {
+                $this->_owApp->appendMessage(
+                    new OntoWiki_Message('The given String is no legal URI (http://...)', OntoWiki_Message::ERROR)


"String" is a very technical term in this case, better use "value"

white-gecko · 2016-10-14T11:56:12Z

application/controllers/ModelController.php

                return;
+            } else if (!Erfurt_Uri::check($newModelUri)) {
+                $this->_owApp->appendMessage(
+                    new OntoWiki_Message('The given String is no legal URI (http://...)', OntoWiki_Message::ERROR)


Since we are aiming for IRI support, it is better to write IRI or URI (resp. other way round)

Also check if the check supports IRIs

shinobu · 2016-10-19T21:11:29Z

done in AKSW/Erfurt#129 --- is the error message ok?

shinobu · 2016-11-02T20:38:17Z

now uses error codes to check if the exception gets catched or not

white-gecko · 2017-05-02T09:51:26Z

Do URNs (urn:…) and https:// URI still work?

shinobu · 2017-05-02T15:36:13Z

are urn:'s really valid RDF/Modelnames?

*edit
this change will make them viable choices as well

white-gecko · 2017-05-03T08:29:28Z

What about ftp://… and tel:… I think there are more valid kinds of URIs resp. IRIs and afaik all of them are allowed for models.

https://tools.ietf.org/html/rfc3986
https://tools.ietf.org/html/rfc3987

https://en.wikipedia.org/wiki/Uniform_Resource_Identifier
https://en.wikipedia.org/wiki/Internationalized_Resource_Identifier

shinobu · 2017-05-12T19:26:11Z

We are now using the PHP filter FILTER_VALIDATE_URL, We might need to add a test (the ModelController has no tests at all right now) to check if the filter works for all PHP versions though.

white-gecko · 2017-05-12T21:48:14Z

Could you add the test?

white-gecko

Finally please rebase and squash the commits.

white-gecko · 2017-06-20T09:25:06Z

application/tests/integration/controller/ModelControllerTest.php

+            ['urn:oasis:names:specification:docbook:dtd:xml:4.1.2', true],
+            ['https://www.aksw.org/faq', true],
+            ['ptth://www.aksw.org', true],
+            ['\\äüö', false]


Please add some more failing examples

white-gecko · 2017-06-20T09:25:25Z

application/tests/integration/controller/ModelControllerTest.php

+    public function testCreateActionFiltersOnlyIncorrectUris($uri, $correctUri)
+    {
+
+


Please also check the coding standard with code sniffer

white-gecko · 2017-06-28T09:37:28Z

application/controllers/ModelController.php

+                    new OntoWiki_Message(
+                        'Given Knowledge Base already exists.',
+                        OntoWiki_Message::ERROR
+                    )


Why do you touch this twice?

white-gecko · 2017-06-28T09:37:40Z

application/controllers/ModelController.php

 *
- * @copyright Copyright (c) 2006-2016, {@link http://aksw.org AKSW}
+ * @copyright Copyright (c) 2006-2017, {@link http://aksw.org AKSW}
 * @license   http://opensource.org/licenses/gpl-license.php GNU General Public License (GPL)


This can go to the first commit.

adds a test for the filter and adds frontendlogin into the ControllerTestCase.php

shinobu · 2017-07-08T16:26:58Z

Done @white-gecko
This should be mergeable now

shinobu force-pushed the fix/CreationCheckIsUri branch 2 times, most recently from 39d59ca to d4934ba Compare October 10, 2016 14:56

shinobu assigned pfrischmuth Oct 10, 2016

white-gecko suggested changes Oct 14, 2016

View reviewed changes

shinobu force-pushed the fix/CreationCheckIsUri branch from d4934ba to 0830280 Compare October 14, 2016 22:25

shinobu force-pushed the fix/CreationCheckIsUri branch from 0830280 to 28861fc Compare November 2, 2016 20:29

shinobu mentioned this pull request Nov 13, 2016

Using a non-existing iri for RDFa import and Linked Data Wrapper throws: Unable to Connect to [website] #397

Open

shinobu force-pushed the fix/CreationCheckIsUri branch from 28861fc to 4f0081d Compare April 23, 2017 19:21

white-gecko assigned shinobu May 2, 2017

shinobu force-pushed the fix/CreationCheckIsUri branch from 4f0081d to b42a80f Compare May 2, 2017 17:46

shinobu force-pushed the fix/CreationCheckIsUri branch from b42a80f to 5c3ae49 Compare May 12, 2017 19:16

white-gecko modified the milestone: 1.1 May 16, 2017

shinobu force-pushed the fix/CreationCheckIsUri branch from faa4e24 to aebe011 Compare June 11, 2017 14:32

white-gecko suggested changes Jun 20, 2017

View reviewed changes

white-gecko unassigned pfrischmuth Jun 20, 2017

shinobu force-pushed the fix/CreationCheckIsUri branch from b7a6132 to 99d1b39 Compare June 20, 2017 16:16

white-gecko suggested changes Jun 28, 2017

View reviewed changes

filters incorrect URIs for knowledge base creation out

d28de85

adds a test for the filter and adds frontendlogin into the ControllerTestCase.php

shinobu force-pushed the fix/CreationCheckIsUri branch from 99d1b39 to d28de85 Compare July 8, 2017 15:26

white-gecko approved these changes Jul 10, 2017

View reviewed changes

white-gecko merged commit 9c20df6 into develop Jul 10, 2017

white-gecko deleted the fix/CreationCheckIsUri branch July 10, 2017 09:15

		public function testCreateActionFiltersOnlyIncorrectUris($uri, $correctUri)
		{

Conversation

shinobu commented Oct 4, 2016

Uh oh!

white-gecko left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shinobu commented Oct 19, 2016

Uh oh!

shinobu commented Nov 2, 2016

Uh oh!

white-gecko commented May 2, 2017

Uh oh!

shinobu commented May 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

white-gecko commented May 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shinobu commented May 12, 2017

Uh oh!

white-gecko commented May 12, 2017

Uh oh!

white-gecko left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shinobu commented Jul 8, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shinobu commented May 2, 2017 •

edited

Loading

white-gecko commented May 3, 2017 •

edited

Loading