Fix code review issues: missing imports, duplicate lock, and MPI file I/O#600
Merged
johanneshofmann87 merged 2 commits into316-implement-hamiltonian-variables-checkfrom Feb 15, 2026
Conversation
… spelling and indentation Co-authored-by: johanneshofmann87 <129625831+johanneshofmann87@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement Hamiltonian variables check
Fix code review issues: missing imports, duplicate lock, and MPI file I/O
Feb 15, 2026
johanneshofmann87
approved these changes
Feb 15, 2026
johanneshofmann87
approved these changes
Feb 15, 2026
55a323b
into
316-implement-hamiltonian-variables-check
165 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses code review feedback on PR #566 (QMC runtime variables implementation).
Changes
Added module-level imports:
output_unitanderror_unitfromiso_fortran_envinQMC_runtime_var_mod.F90to fix compilation errors where symbols were used without importRemoved duplicate lock: Eliminated redundant
lock_QMC_runtime_settings()call inmain.F90:485since it's already called insidecheck_update_schemes_compatibility():234Fixed MPI file I/O: Wrapped file operations in
read_and_broadcast_TEMPERING_var()with rank 0 check to prevent multiple processes from reading the same file💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.