Fix Compute_Ratio_Global call sites for log-scale signature change#603
Merged
johanneshofmann87 merged 6 commits into601-global-moves-with-proposal-probability-on-log-scalefrom Feb 16, 2026
Conversation
Co-authored-by: johanneshofmann87 <129625831+johanneshofmann87@users.noreply.github.com>
Co-authored-by: johanneshofmann87 <129625831+johanneshofmann87@users.noreply.github.com>
Co-authored-by: johanneshofmann87 <129625831+johanneshofmann87@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add global moves with proposal probability on log scale
Add Global_move_log_T0 for numerical stability with extreme proposal probabilities
Feb 16, 2026
Co-authored-by: johanneshofmann87 <129625831+johanneshofmann87@users.noreply.github.com>
Copilot
AI
changed the title
Add Global_move_log_T0 for numerical stability with extreme proposal probabilities
Fix Compute_Ratio_Global call sites for log-scale signature change
Feb 16, 2026
…' into copilot/add-global-moves-log-scale
johanneshofmann87
approved these changes
Feb 16, 2026
b05925a
into
601-global-moves-with-proposal-probability-on-log-scale
164 of 165 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compute_Ratio_Globalsignature changed to acceptlog_T0_proposal_ratiobut two call sites (Langevin HMC and parallel tempering) were not updated.Changes
Prog/Langevin_HMC_mod.F90
T0_Proposal_ratio→log_T0_Proposal_ratio1.0→0.0d0Prog/Global_mod.F90 (Exchange_Step)
T0_Proposal_ratio→log_T0_Proposal_ratio1.d0→0.d0All three call sites in the codebase now use the log-scale interface consistently.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.