Conversation
pasabanov
added
feature
There was a problem hiding this comment.
Pull Request Overview
This pull request adds new spline data generation functionality, including generator scripts for step, linear, quadratic, and cubic splines as well as updates to verification code to include the new spline files. Key changes include:
- New generator scripts in the “spline” folder that compute spline values and coefficients.
- New TOML files with test case arrays for various spline types.
- Minor refactoring fixes in existing generator files to standardize number formatting.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| verify_data.py | Added test case checks for the new spline-generated TOML files. |
| spline/*.toml | New spline configuration files with test case data for various types. |
| spline/generate_*.py | New generator scripts for step, linear, quadratic, and cubic splines. |
| poly/generate.py, misc/generate.py | Updates to the uniform function for consistency. |
pasabanov
force-pushed
the
spline
branch
2 times, most recently
from
ea85d2c to
d274d5f
Compare
1. Added generator scripts and generated files: - `spline/generate_step.py` -> `spline/step.toml`; - `spline/generate_linear.py` -> `spline/linear.toml`; - `spline/generate_quadratic.py` -> `spline/quadratic.toml`; - `spline/generate_cubic.py` -> `spline/cubic.toml`. 2. Performed minor refactoring and fixes in other files.
This was referenced Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Related: #1 #9 #11
Description
Added generator scripts and the generated files:
spline/generate_step.py->spline/step.tomlspline/generate_linear.py->spline/linear.tomlspline/generate_quadratic.py->spline/quadratic.tomlspline/generate_cubic.py->spline/cubic.tomlPerformed minor refactoring and fixes in other files.