fix(ci): preserve JSON structure of changes output in build-matrix step#104
Merged
coleramos425 merged 3 commits intomainfrom Apr 1, 2026
Merged
fix(ci): preserve JSON structure of changes output in build-matrix step#104coleramos425 merged 3 commits intomainfrom
changes output in build-matrix step#104coleramos425 merged 3 commits intomainfrom
Conversation
Agent-Logs-Url: https://github.com/AMDResearch/intellikit/sessions/9d165719-f883-4883-9ec1-77f1c292214f Co-authored-by: coleramos425 <11466906+coleramos425@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CI failure caused by fromJson JSON output
fix(ci): preserve JSON structure of Mar 30, 2026
changes output in build-matrix step
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the CI workflow’s “Build package matrix” step so the dorny/paths-filter changes output remains valid JSON when written to GITHUB_OUTPUT, preventing fromJson(...) from failing when only a subset of packages changes.
Changes:
- Store
${{ steps.filter.outputs.changes }}in a single-quoted shell variable before emitting it as a job output. - Update the
packagesoutput emission to use the intermediateCHANGESvariable, preserving JSON quoting.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…lid JSON output Agent-Logs-Url: https://github.com/AMDResearch/intellikit/sessions/f1e2ef4e-1d36-4c43-8df3-289005ba64fc Co-authored-by: coleramos425 <11466906+coleramos425@users.noreply.github.com>
coleramos425
approved these changes
Apr 1, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

fromJsonin thetest-installationstrategy matrix fails on PRs that only modify a subset of packages because thedorny/paths-filterchangesoutput (e.g.,["kerncap","metrix"]) is interpolated inside a double-quotedecho, causing the shell to strip the inner quotes and write invalid JSON ([kerncap,metrix]) toGITHUB_OUTPUT.Change
Assign the expression to a shell variable using single quotes before echoing — the same pattern already used for
ALL:GHA expands
${{ }}before the shell runs, so the shell seesCHANGES='["kerncap","metrix"]'; single quotes preserve the JSON intact.