Added libzstd-dev to system dependencies#110
Merged
Conversation
KernelDB links against libzstd (src/CMakeLists.txt), so libzstd-dev is required at build time. Updated install script, Dockerfile, Apptainer def, docs, and READMEs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates system dependency prerequisites to include Zstandard development headers, aligning the install flow and container images with KernelDB’s zstd linkage requirements for building accordo and nexus.
Changes:
- Add
libzstd-dev/libzstd-develto prerequisite lists across top-level docs and tool docs. - Update
install/tools/install.shto check forlibzstd-dev/libzstd-develand fail early when missing. - Install
libzstd-devin the Dockerfile and Apptainer definition.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Adds libzstd-dev to accordo/nexus prerequisites and updates the explanatory note. |
| install/tools/install.sh | Extends native dependency checks to include libzstd dev packages. |
| docs/src/content/docs/tools/nexus.mdx | Updates Nexus install prerequisites to include libzstd-dev. |
| docs/src/content/docs/tools/accordo.mdx | Updates Accordo install prerequisites to include libzstd-dev. |
| docs/src/content/docs/getting-started/installation.mdx | Adds libzstd packages to prerequisites and install commands. |
| docker/Dockerfile | Installs libzstd-dev in the base image. |
| apptainer/intellikit.def | Installs libzstd-dev in the Apptainer image definition. |
| accordo/README.md | Updates Accordo README prerequisite commands for Debian/Fedora families. |
Comments suppressed due to low confidence (1)
docs/src/content/docs/getting-started/installation.mdx:44
- The docs say the install script “will warn” if these system packages are missing, but
install/tools/install.shcurrently prints an error and exits (unless--dry-run). Please update this sentence to reflect the actual behavior (e.g., “errors and exits” / “fails fast”).
The install script (`install/tools/install.sh`) will warn if these are missing. The
[IntelliKit Docker image](https://github.com/AMDResearch/intellikit/blob/main/docker/Dockerfile) includes them already.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | GPU | MI300+ for the full GPU experience; some tools vary — see each tool's page | | ||
| | uProf | AMD uProf on x86 for `uprof_mcp` only | | ||
| | cmake, libdwarf-dev | Required by **accordo** and **nexus** (C++ build via KernelDB). See below. | | ||
| | cmake, libdwarf-dev, libzstd-dev | Required by **accordo** and **nexus** (C++ build via KernelDB). See below. | |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
README.md
Outdated
| | uProf | **AMD uProf** on **x86** for `uprof_mcp` only — see that README | | ||
|
|
||
| > **System packages for accordo / nexus:** These tools compile C++ code (via [KernelDB](https://github.com/AMDResearch/KernelDB)) during `pip install`. Install `cmake` and `libdwarf-dev` (`libdwarf-devel` on Fedora/RHEL) first, or the build will fail. The [IntelliKit Docker image](docker/Dockerfile) and `install.sh` already handle this. See [docs](https://amdresearch.github.io/intellikit/getting-started/installation/) for details. | ||
| > **System packages for accordo / nexus:** These tools compile C++ code (via [KernelDB](https://github.com/AMDResearch/KernelDB)) during `pip install`. Install `cmake`, `libdwarf-dev`, and `libzstd-dev` (`libdwarf-devel`/`libzstd-devel` on Fedora/RHEL) first, or the build will fail. The [IntelliKit Docker image](docker/Dockerfile) and `install.sh` already handle this. See [docs](https://amdresearch.github.io/intellikit/getting-started/installation/) for details. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…rding Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/CMakeLists.txtlinks againstzstd, makinglibzstd-deva required system package for building accordo and nexuslibzstd-dev/libzstd-devellibzstd-devTest plan
src/CMakeLists.txtlinkszstdviagh search codelibdwarf-devto also includelibzstd-dev🤖 Generated with Claude Code