[FIX] Standardise sigma coords on rapid to be <1000#126
Merged
eleanorfrajka merged 3 commits intomainfrom Feb 22, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request standardizes sigma coordinate values in RAPID's "meridional_transports.nc" file to use potential density anomalies (values < 100) instead of absolute potential density values (values > 1000), bringing them into consistency with OSNAP data formatting conventions.
Changes:
- Added coordinate transformation logic to subtract 1000 from sigma0 and sigma2 values when they exceed 100
- Updated documentation to reflect the new coordinate value ranges (sigma0: 22.00-28.00, sigma2: 30.00-37.15)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| amocatlas/data_sources/rapid26n.py | Implements sigma coordinate transformation in the RAPID data reader for meridional_transports.nc file |
| docs/source/reports/rapid_report.rst | Updates coordinate value ranges in documentation to reflect the transformation from absolute density to anomaly values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
RAPID's "meridional_transports.nc" file uses sigma values which are not anomalies. Subtracting 1000 to be consistent with OSNAP.
Also update to latest version of FBC data.