Skip to content

fix: Support both development and production builds in Electron #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
upendra512 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Support both development and production builds in Electron #326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 27 additions & 5 deletions electron/main.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,22 +39,44 @@ function waitForServer(url) {
});
}

// Start Nitro server (production)
// Start Nitro server (development or production)
function startServer() {
return new Promise((resolve) => {
const serverPath = path.join(
// Try development path first (after npm run build)
const devPath = path.join(process.cwd(), '.output', 'server', 'index.mjs');

// Fallback to production path (after npm run dist)
const prodPath = path.join(
process.resourcesPath,
'app.asar.unpacked',
'.output',
'server',
'index.mjs'
);

console.log("Starting server from:", serverPath);
// Determine which path to use
let serverPath;
let isDevelopment = false;

if (fs.existsSync(devPath)) {
serverPath = devPath;
isDevelopment = true;
console.log("Starting server in DEVELOPMENT mode from:", serverPath);
} else if (fs.existsSync(prodPath)) {
serverPath = prodPath;
console.log("Starting server in PRODUCTION mode from:", serverPath);
} else {
console.error("ERROR: Server build not found!");
console.error("Tried development path:", devPath);
console.error("Tried production path:", prodPath);
console.error("Please run 'npm run build' first.");
app.quit();
return;
}

serverProcess = spawn('node', [serverPath], {
stdio: 'ignore', // no terminal
windowsHide: true, // hide CMD
stdio: isDevelopment ? 'inherit' : 'ignore', // show logs in dev
windowsHide: !isDevelopment, // show terminal in dev
env: {
...process.env,
HOST: serverHost,
Expand Down
Loading