fix: move themeColor and viewport to viewport export (Next.js 13.4+)#313
Open
Alishasaroha wants to merge 1 commit intoAOSSIE-Org:devfrom
Open
fix: move themeColor and viewport to viewport export (Next.js 13.4+)#313Alishasaroha wants to merge 1 commit intoAOSSIE-Org:devfrom
Alishasaroha wants to merge 1 commit intoAOSSIE-Org:devfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @Alishasaroha, which issue is this PR resolving? I think this PR is for #310? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
##Description
🐛 Fix: Move
themeColorandviewportto Next.jsviewportexportBackground
Since Next.js 13.4+, viewport-related fields such as
themeColorandviewportwere moved from themetadataobject into a dedicatedviewportexport. Keeping them insidemetadatatriggers a Next.js warning and may prevent the browser from correctly applying these values.Changes
themeColorandviewportfrom themetadataexportexport const viewportinapp/layout.jswith:themeColorwidthinitialScaleResult
<meta name="theme-color"><meta name="viewport">Reference
Next.js docs:
https://nextjs.org/docs/app/api-reference/functions/generate-viewport