Add YouTube Button to Redirect to Official Channel (#314)#315
Add YouTube Button to Redirect to Official Channel (#314)#315ankitkr104 wants to merge 2 commits intoAOSSIE-Org:mainfrom
Conversation
📝 WalkthroughWalkthroughAdded a YouTube icon import and a new YouTube social link button to the About component; the link opens the official YouTube channel in a new browser tab. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@app/components/About/About.jsx`:
- Around line 42-44: The YouTube anchor around the FaYoutube icon is missing
target="_blank" and rel="noopener noreferrer"; update the anchor element that
contains <FaYoutube /> (and other social link anchors if you want consistency)
to include target="_blank" and rel="noopener noreferrer" so the link opens in a
new tab safely, ensuring you add both attributes to the <a> element that wraps
FaYoutube.
app/components/About/About.jsx
Outdated
| <a href="https://youtu.be/IWtFc72BNhM?si=LbgN2t3A3pOE4P-Y"> | ||
| <FaYoutube /> | ||
| </a> |
There was a problem hiding this comment.
target="_blank" and rel="noopener noreferrer" are missing.
The PR description and issue #314 both explicitly state the link should open in a new tab with secure redirection, but neither attribute is present on the new anchor. All other existing social links also lack these attributes, so this gap is systemic — but this PR is the right place to introduce the pattern since it is the stated intent.
🛠️ Proposed fix
- <a href="https://youtu.be/IWtFc72BNhM?si=LbgN2t3A3pOE4P-Y">
+ <a href="https://www.youtube.com/@<official-channel-handle>" target="_blank" rel="noopener noreferrer">
<FaYoutube />
</a>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@app/components/About/About.jsx` around lines 42 - 44, The YouTube anchor
around the FaYoutube icon is missing target="_blank" and rel="noopener
noreferrer"; update the anchor element that contains <FaYoutube /> (and other
social link anchors if you want consistency) to include target="_blank" and
rel="noopener noreferrer" so the link opens in a new tab safely, ensuring you
add both attributes to the <a> element that wraps FaYoutube.
|
hey @M4dhav , This PR introduces a small but useful enhancement by adding a YouTube button that redirects users to the official channel. The implementation follows the existing UI design, maintains responsiveness, and uses secure external redirection. It does not introduce any breaking changes or affect existing functionality. Since this is a minor and beneficial feature, I kindly request the maintainers to review and merge it once the pending checks are completed. Thank you. |
|
Hey @ankitkr104 |
Added target='_blank' to YouTube link for external opening.
ankitkr104
left a comment
ankitkr104
left a comment
There was a problem hiding this comment.
Thank you for the suggestion @M4dhav ,
I have updated the YouTube anchor tag to include target="_blank" so it now opens in a new tab.
Please review the latest changes.
There was a problem hiding this comment.
♻️ Duplicate comments (1)
app/components/About/About.jsx (1)
42-44:⚠️ Potential issue | 🟡 MinorTwo issues from the prior review remain unresolved: wrong URL and missing
rel.
Wrong URL (functional) —
https://youtu.be/IWtFc72BNhM?si=LbgN2t3A3pOE4P-Yis a share link to a single video, not the official YouTube channel page. The PR objective and issue#314both explicitly require a link to the channel.Missing
rel="noopener noreferrer"(security) —target="_blank"withoutrel="noopener noreferrer"leaveswindow.openeraccessible to the linked page, enabling reverse tabnapping.🛠️ Proposed fix
- <a href="https://youtu.be/IWtFc72BNhM?si=LbgN2t3A3pOE4P-Y" target="_blank"> + <a href="https://www.youtube.com/@AossieOrg" target="_blank" rel="noopener noreferrer"> <FaYoutube /> </a>Replace
@AossieOrgwith the actual official channel handle if it differs.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@app/components/About/About.jsx` around lines 42 - 44, The anchor in the About component uses a single-video share URL and omits rel; update the <a> element in About (About.jsx) that wraps <FaYoutube /> to point to the official YouTube channel URL (not a youtu.be video link) and add rel="noopener noreferrer" alongside target="_blank"; if the channel handle differs replace the placeholder/@AossieOrg with the actual official channel handle in the href.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@app/components/About/About.jsx`:
- Around line 42-44: The anchor in the About component uses a single-video share
URL and omits rel; update the <a> element in About (About.jsx) that wraps
<FaYoutube /> to point to the official YouTube channel URL (not a youtu.be video
link) and add rel="noopener noreferrer" alongside target="_blank"; if the
channel handle differs replace the placeholder/@AossieOrg with the actual
official channel handle in the href.
Hey i'm not a maintainer, i'm just a contributor trying to help. |
ayush00git
left a comment
ayush00git
left a comment
There was a problem hiding this comment.
I think the link should be to the main AOSSIE"s youtube channel
change the link to this - https://www.youtube.com/@AOSSIE-Org
|
Hey @ayush00git , In future if any channel is created then we add into them. |
2 participants
Description
This PR adds a YouTube button to the website that redirects users to the official YouTube channel.
The button has been added to the appropriate section (header/footer) following the existing UI design and styling conventions. It opens the YouTube link in a new tab using secure redirection (target="_blank" with rel="noopener noreferrer").
This enhancement improves accessibility to video content, tutorials, and updates, and strengthens community engagement.
Fixes #314
Summary by CodeRabbit