fix: add noopener noreferrer and aria-labels to external links#337
fix: add noopener noreferrer and aria-labels to external links#337JaiswalShivang wants to merge 1 commit intoAOSSIE-Org:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds security and accessibility attributes to external social links in About.jsx. The changes include adding Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can make CodeRabbit's review stricter and more nitpicky using the `assertive` profile, if that's what you prefer.Change the |
Description
This PR addresses security and accessibility issues found in the external links within the
FooterandAboutcomponents.rel="noopener noreferrer"to all links usingtarget="_blank"to prevent reverse tabnabbing vulnerabilities.aria-labelattributes to all icon-only social links (using React Icons) so they are properly announced by screen readers.Fixes #124
Type of change
How Has This Been Tested?
npm run buildto ensure the production build compiles successfully. (Note: The warnings generated during the build are related to deprecated Next.js metadata in thelayout.js/page.jsfiles, not this PR).relandaria-labelattributes without altering the visual UI.npm testwas skipped as there is currently no test script configured inpackage.json.)Checklist:
Maintainer Checklist
Summary by CodeRabbit