fix: optimize hero image and migrate to next/image#346
Open
van456-dot wants to merge 2 commits intoAOSSIE-Org:mainfrom
Open
fix: optimize hero image and migrate to next/image#346van456-dot wants to merge 2 commits intoAOSSIE-Org:mainfrom
van456-dot wants to merge 2 commits intoAOSSIE-Org:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughConverted native HTML Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can approve the review once all CodeRabbit's comments are resolved.Enable the |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@app/components/Layout/NavBar/Navbar.css`:
- Around line 33-35: Remove the hardcoded CSS dimensions in Navbar.css (the
width: 13.48px and height: 24px rules) that conflict with the JSX Image props;
instead let the Image's width/height props control size and/or apply a matching
CSS class that does not override those props. Then update the Image in the
NavBar component (the Image element in app/components/Layout/NavBar/index.jsx)
so its width and height props match the intended display size (choose and set
either width={13} height={24} or width={40} height={40} consistently) and ensure
no other CSS selector in Navbar.css forces different dimensions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 8a2bb7f6-2d57-4b4c-ba9b-1611f43c87f3
⛔ Files ignored due to path filters (1)
app/assets/resonate_app.pngis excluded by!**/*.png
📒 Files selected for processing (8)
app/assets/resonate_app.webpapp/components/About/About.jsxapp/components/DownloadApp/DownloadApp.jsxapp/components/Features/Features.jsxapp/components/Hero/Hero.jsxapp/components/Layout/NavBar/Navbar.cssapp/components/Layout/NavBar/index.jsxapp/components/TechStack/TechStack.jsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves image performance and loading behavior across the website by optimizing assets and using Next.js best practices.
Fixes #344
Changes made:
Converted large hero image (
resonate_app.png) to WebP format (~144KB)Migrated multiple components from
<img>tonext/image:Ensured compatibility with static export by retaining
images.unoptimized: trueinnext.config.jsMotivation & Context:
The project currently uses static export (
output: 'export'), which disables Next.js Image Optimization API.However, using
next/imagestill provides benefits like responsive loading and better layout handling.Additionally, existing PNG images were relatively large (>200KB) and already showed pixelation on zoom. Converting them to WebP reduces size significantly without noticeable quality loss in normal usage.
Type of change
How Has This Been Tested?
npm run devnext/imageScreenshots:
(Add before/after screenshots here if possible)
Checklist:
Maintainer Checklist
Summary by CodeRabbit
Refactor
Style