Open
Conversation
diamondap
reviewed
Dec 17, 2025
Member
diamondap
left a comment
diamondap
left a comment
There was a problem hiding this comment.
Looks good so far. See comment on util/util.go. Looks like this is a work in progress and we can't fully test it until other PRs related to db changes have been merged. We'll circle back to this one later.
Member
There was a problem hiding this comment.
The Convert functions in util/util.go need to be fleshed out.
…d so we do not wipe out the CFN changes and cause regression.
Updating the CFN default template for the make update-template comman…
…iles.
This update removes our custom DefaultMinioPutOptions in favor of the standard minio.PutObjectOptions{}. Our former DefaultMinioPutOptions were experimental and included settings to work with Wasabi. We are no longer using Wasabi, so we no longer need those settings. In addition, those old Wasabi-specific settings cause problems with the latest minio-go client when uploading files of unknown size (size = -1) because the old Wasabi-specific settings, with their hard-coded checksum algorithm, prevented minio-go from choosing the proper checksum algorithm for files of unknown size. This resulted in failed uploads. https://trello.com/c/53T5k08v
…efix. The endpoint prefix for preservation services will always be "admin-api." This fix is for DART 3, which borrows the RegistryClient and needs to call "member-api." https://trello.com/c/xU77Ploy
S3 large files merges the latest minio client for s3 objects. The primary change for APTrut on this merge is increasing the S3 object size allowed from 5TB to 50TBs.
MetadataGatherer now uses new GetLargeObject call to download bags la…
StagingUploader now also uses GetLargeObject for files over 5TB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to shrink the Postgres database, changes need to be made to code referencing the PREMIS event's event_type. The event_type will now be stored as an int, not a string, to save space. We can also save these values as constants, and continue to use them in code.