Skip to content

Update bookmarks.routes.ts #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RickyRAV merged 1 commit into from
Apr 23, 2025
Merged

Update bookmarks.routes.ts #144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 29 additions & 7 deletions apps/api/src/api/v1/bookmarks.routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,16 @@ import { resolver, validator as zValidator } from "hono-openapi/zod";
import prettyMilliseconds from "pretty-ms";
import { z } from "zod";
import {
bookmarks,
multiplayerQuizSubmissions,
quizzes,
bookmarks,
multiplayerQuizSubmissions,
quizzes,
} from "../../../drizzle/schema";
import { createDb } from "../../db/index";
import { getSupabase } from "./middleware/auth.middleware";
import { quizType } from "./schemas/common.schemas";
import {
historyQuerySchema,
quizHistoryResponseSchema,
historyQuerySchema,
quizHistoryResponseSchema,
} from "./schemas/history.schemas";

const bookmarksRoutes = new Hono<{ Bindings: CloudflareEnv }>()
Expand Down Expand Up @@ -389,6 +389,7 @@ const bookmarksRoutes = new Hono<{ Bindings: CloudflareEnv }>()
.select({
id: quizzes.id,
userId: quizzes.userId,
type: quizzes.type,
})
.from(quizzes)
.where(eq(quizzes.id, id));
Expand All @@ -397,9 +398,30 @@ const bookmarksRoutes = new Hono<{ Bindings: CloudflareEnv }>()
throw new Error("Quiz not found");
}

// Check if quiz belongs to user
// TODO: This is temporary, just to make it work for LAUNCHWEEK-01
// Check user permission - allow if:
// 1. User is the quiz creator, OR
// 2. It's a multiplayer quiz and user has participated
if (quiz.userId !== user!.id) {
throw new Error("Not authorized to bookmark this quiz");
// If not owner, check if it's a multiplayer quiz the user participated in
if (quiz.type !== quizType.Enum.multiplayer) {
throw new Error("Not authorized to bookmark this quiz");
}

// Check if user has participated in this multiplayer quiz
const [participation] = await tx
.select()
.from(multiplayerQuizSubmissions)
.where(
and(
eq(multiplayerQuizSubmissions.quizId, id),
eq(multiplayerQuizSubmissions.userId, user!.id),
),
);

if (!participation) {
throw new Error("Not authorized to bookmark this quiz");
}
}

// Check if already bookmarked
Expand Down