Skip to content

Fix M1_UART_2: accept both console and legacy console printk messages#37

Merged
amrathesh merged 1 commit intoARM-software:mainfrom
Guru9902:main
Sep 8, 2025
Merged

Fix M1_UART_2: accept both console and legacy console printk messages#37
amrathesh merged 1 commit intoARM-software:mainfrom
Guru9902:main

Conversation

@Guru9902
Copy link
Contributor

@Guru9902 Guru9902 commented Sep 8, 2025

Summary

The M1_UART_2 test in test_ipmi_outband_sol.robot currently fails on
systems where the kernel enables the UART console in "legacy" mode.
Such systems produce the log line:

printk: legacy console [ttyAMA0] enabled

instead of:

printk: console [ttyAMA0] enabled

Although the console is fully functional and BSA-compliant, the test
does not detect it and reports a false failure.

Changes

  • Updated the regex in Verify BSA Compliant UART From Boot Log to
    accept both console and legacy console printk messages.
  • Extracts the TTY device (e.g. ttyAMA0) from either case.

Impact

  • Prevents false negatives when only a legacy console is present.
  • Maintains compliance verification logic: the console TTY is still
    checked against the ACPI SPCR table for BSA compliance.
  • No effect on systems already passing with the non-legacy message.

Issue

Fixes #36

- Updated test_ipmi_outband_sol.robot to handle both
  "printk: console [ttyXXX] enabled" and
  "printk: legacy console [ttyXXX] enabled"
- Regex updated to capture the TTY device name consistently
- Ensures systems exposing only a legacy console (e.g. ttyAMA0)
  are still treated as compliant

Signed-off-by: Guru9902 <gururaj.revankar@arm.com>
@amrathesh amrathesh merged commit 542f948 into ARM-software:main Sep 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

M1_UART_2: Support for systems using legacy console drivers

2 participants