Skip to content

Align IOVIRT_BLOCK to the correct length#7

Closed
ownia wants to merge 1 commit intoARM-software:mainfrom
ownia:fix/IOVIRT_BLOCK
Closed

Align IOVIRT_BLOCK to the correct length#7
ownia wants to merge 1 commit intoARM-software:mainfrom
ownia:fix/IOVIRT_BLOCK

Conversation

@ownia
Copy link

@ownia ownia commented Jun 25, 2025

Migrated from ARM-software/bsa-acs#503

This PR fixes a bug for GET_SMMU_INFO. Currently there are two definitions of MAX_NAMED_COMP_LENGTH: 150 and 256, this will cause inconsistent IOVIRT_BLOCK size and trigger warning to block the SMMU test. Set all MAX_NAMED_COMP_LENGTH to 150 to fix it.

 SMMU_INFO: Number of SMMU CTRL       :    2
 SMMU_INFO: SMMU index 00 version     :    v3.1
GET_SMMU_INFO: Index (1) is greater than num of SMMU
 SMMU_INFO: SMMU index 01 version     :    v0

Signed-off-by: Weizhao Ouyang <weizhao.ouyang@arm.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ownia,

The PR description correctly mentions to make all IOVIRT_LENGTH to 150, but the changes in PR is changing them to 256.
We are internally raising PR to fix length in one file. pal/uefi_dt/include/pal_uefi.h

Copy link
Author

@ownia ownia Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are internally raising PR to fix length in one file. pal/uefi_dt/include/pal_uefi.h

good! :)

@chetan-rathore
Copy link
Contributor

Hi @ownia,

The internal PR to correct the MAX_NAMED_COMP_LENGTH is corrected in pal/uefi_dt/include/pal_uefi.h
Thanks for original PR on bsa branch

Thanks,
Chetan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants