Skip to content

Refine verification steps of EVES-003 for DB synchronization. #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdsika merged 1 commit into from
Nov 25, 2024
Merged

Refine verification steps of EVES-003 for DB synchronization. #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions EVES/drafts/EVES-003/eves-003.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,9 @@

- Use a listener to detect mint events and synchronize data with the ENVITED-X database.
- Verify that data referenced in the token metadata is the same as stored in Step 2).
- If asset is not yet in DB then mark it as foreign asset and add the `publisher`information to the DB.

Check notice on line 101 in EVES/drafts/EVES-003/eves-003.md

View workflow job for this annotation

GitHub Actions / vale

[vale] EVES/drafts/EVES-003/eves-003.md#L101 

[write-good.E-Prime] Try to avoid using 'is'.
Raw output 
{"message": "[write-good.E-Prime] Try to avoid using 'is'.", "location": {"path": "EVES/drafts/EVES-003/eves-003.md", "range": {"start": {"line": 101, "column": 12}}}, "severity": "INFO"}

Check notice on line 101 in EVES/drafts/EVES-003/eves-003.md

View workflow job for this annotation

GitHub Actions / vale

[vale] EVES/drafts/EVES-003/eves-003.md#L101 

[Google.Contractions] Use 'isn't' instead of 'is not'.
Raw output 
{"message": "[Google.Contractions] Use 'isn't' instead of 'is not'.", "location": {"path": "EVES/drafts/EVES-003/eves-003.md", "range": {"start": {"line": 101, "column": 12}}}, "severity": "INFO"}
- Verify the asset in reverse order as in step 1).
- Only public information of assets can be verified if uploaded through another application then ENVITED-X.

Check notice on line 103 in EVES/drafts/EVES-003/eves-003.md

View workflow job for this annotation

GitHub Actions / vale

[vale] EVES/drafts/EVES-003/eves-003.md#L103 

[Google.Passive] In general, use active voice instead of passive voice ('be verified').
Raw output 
{"message": "[Google.Passive] In general, use active voice instead of passive voice ('be verified').", "location": {"path": "EVES/drafts/EVES-003/eves-003.md", "range": {"start": {"line": 103, "column": 41}}}, "severity": "INFO"}

Check notice on line 103 in EVES/drafts/EVES-003/eves-003.md

View workflow job for this annotation

GitHub Actions / vale

[vale] EVES/drafts/EVES-003/eves-003.md#L103 

[write-good.E-Prime] Try to avoid using 'be'.
Raw output 
{"message": "[write-good.E-Prime] Try to avoid using 'be'.", "location": {"path": "EVES/drafts/EVES-003/eves-003.md", "range": {"start": {"line": 103, "column": 41}}}, "severity": "INFO"}

Check warning on line 103 in EVES/drafts/EVES-003/eves-003.md

View workflow job for this annotation

GitHub Actions / vale

[vale] EVES/drafts/EVES-003/eves-003.md#L103 

[write-good.Passive] 'be verified' may be passive voice. Use active voice if you can.
Raw output 
{"message": "[write-good.Passive] 'be verified' may be passive voice. Use active voice if you can.", "location": {"path": "EVES/drafts/EVES-003/eves-003.md", "range": {"start": {"line": 103, "column": 41}}}, "severity": "WARNING"}

Check warning on line 103 in EVES/drafts/EVES-003/eves-003.md

View workflow job for this annotation

GitHub Actions / vale

[vale] EVES/drafts/EVES-003/eves-003.md#L103 

[Google.WordList] Use 'app' instead of 'application'.
Raw output 
{"message": "[Google.WordList] Use 'app' instead of 'application'.", "location": {"path": "EVES/drafts/EVES-003/eves-003.md", "range": {"start": {"line": 103, "column": 81}}}, "severity": "WARNING"}

### 5. Database Synchronization

Expand Down
Loading