SlimSAR Time-domain Backprojection job spec file #3000
Conversation
…hyp3-slimsar-test deployment CI CD deployment matrix and changelog
…mage to conda version
| cost: 1.0 | ||
| steps: | ||
| - name: '' | ||
| image: 242399506617.dkr.ecr.us-west-2.amazonaws.com/hyp3-slimsar |
There was a problem hiding this comment.
I don't see test tagged image, so the hyp3-slimsar-test deployment won't find an image to pull, since it defaults to pulling test:
https://github.com/ASFHyP3/hyp3/pull/3000/changes#diff-1b786e2e386dfc278adcccdf6c86d74aa62c13e17abbefda42fcc94ada7d6b85R135
typically, test deployments default to pulling test tagged images and prod deployments default to pulling latest tagged images.
You can override the default in a job_spec with image_tag: as well.
| example: s3://asf-bucket/slimsar/SAR_11072025_110035.sar | ||
| description: Path to uncompressed slimsar echo/raw file on s3 bucket | ||
| type: string | ||
| pattern: "^s3://[a-z0-9.-]+(/[^/]+)*/[^/]+\\.sar$" |
There was a problem hiding this comment.
| pattern: "^s3://[a-z0-9.-]+(/[^/]+)*/[^/]+\\.sar$" | |
| pattern: "^s3:\/\/[a-z0-9.-]+(\/[^/]+)*\/[^/]+\.sar$" |
I think you need to escape the forward slashes and have too many backslashes at the end.
Patterns use ECMA 262 Javascript format:
https://swagger.io/docs/specification/v3_0/data-models/data-types/#pattern
| api_schema: | ||
| type: string | ||
| example: s3://asf-bucket/slimsar/NMZT23520001E_100_proj.dat | ||
| pattern: "^s3://[a-z0-9.-]+(/[^/]+)*/[^/]+\\.dat$" |
There was a problem hiding this comment.
| pattern: "^s3://[a-z0-9.-]+(/[^/]+)*/[^/]+\\.dat$" | |
| pattern: "^s3:\/\/[a-z0-9.-]+(\/[^/]+)*\/[^/]+\.dat$" |
I think you need to escape the forward slashes and have too many backslashes at the end.
Patterns use ECMA 262 Javascript format:
https://swagger.io/docs/specification/v3_0/data-models/data-types/#pattern
| api_schema: | ||
| type: string | ||
| example: s3://asf-bucket/slimsar/repeat_sub.tif | ||
| pattern: "^s3://[a-z0-9.-]+(/[^/]+)*/[^/]+\\.tif$" |
There was a problem hiding this comment.
| pattern: "^s3://[a-z0-9.-]+(/[^/]+)*/[^/]+\\.tif$" | |
| pattern: "^s3:\/\/[a-z0-9.-]+(\/[^/]+)*\/[^/]+\.tif$" |
I think you need to escape the forward slashes and have too many backslashes at the end.
Patterns use ECMA 262 Javascript format:
https://swagger.io/docs/specification/v3_0/data-models/data-types/#pattern
There was a problem hiding this comment.
In the --help for the slimsar image, it has:
--dem_fp DEM_FP Path to DEM .tif/.dem file
do you wantt to support *.dem files in HyP3 too?
| ami_id: ami-0aece254fc7c27a77 # /aws/service/ecs/optimized-ami/amazon-linux-2023/recommended/image_id | ||
| SlimSAR: | ||
| instance_types: g4dn.2xlarge,g4dn.4xlarge,g4dn.6xlarge, | ||
| allocation_type: EC2 |
There was a problem hiding this comment.
I'm not sure, but you may also need to specify a GPU API image like:
ami_id: ami-0729c079aae647cb3 # /aws/service/ecs/optimized-ami/amazon-linux-2/gpu/recommended/image_id
| description: Polarization to process | ||
| maxLength: 2 | ||
| minLength: 2 | ||
| pattern: "^(VV|VH|HV|HH)$" |
There was a problem hiding this comment.
| pattern: "^(VV|VH|HV|HH)$" | |
| type: string | |
| enum: | |
| - VV | |
| - VH | |
| - HV | |
| - HH |
You can be explicit here with an enumerator as well. Either works, though.
This is PR:
I most based this the other job specs. Especially RTC_Gamma.
I don't see any super relevant validators but how critical are those?