Skip to content

UDS-1970: feat(unity-bootstrap-theme): added mixin to expand clickable area #1564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2025
Merged

UDS-1970: feat(unity-bootstrap-theme): added mixin to expand clickable area #1564

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
641eb4e
feat(unity-bootstrap-theme): added mixin to expand clickable area for…
juanmitriatti Jul 16, 2025
6b791b5
feat(unity-bootstrap-theme): applied some feedback changes
juanmitriatti Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/unity-bootstrap-theme/src/scss/extends/_buttons.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,24 @@
1rem;
}

@mixin clickable-area() {
position: relative;
&::before {
content: "";
position: absolute;
inset: -10px;
margin: auto;
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image 
  &::before {
    content: "";
    position: absolute;
    min-width: $min-width; // is not needed, but doesn't hurt
    min-height: $min-height;
    // z-index: -1;
    inset: 0;
    margin: auto;
    right: min(0px, calc(50% - #{$min-width} / 2));
    left: min(0px, calc(50% - #{$min-width} / 2));


    background-color: #f002; // visual testing only
  }

The code above equally expands the clickable area in all directions, The only issue is the overlap with the 1 character buttons, but I think this is an extreme scenario


// Extra styles that don't have bootstrap variables to override
.btn {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I the solution needs to be on the .btn class since buttons are responsive and regular buttons inherit a small class with a narrow viewport.

Image

text-decoration: none;
font-weight: bold;
white-space: nowrap;
width: max-content !important;
@include clickable-area();

&::first-letter {
text-transform: uppercase;
}
Expand Down