Skip to content

adding 3 loop types for connector#28

Open
nicolasmagalhaes wants to merge 2 commits intomasterfrom
adding_connector_loop
Open

adding 3 loop types for connector#28
nicolasmagalhaes wants to merge 2 commits intomasterfrom
adding_connector_loop

Conversation

@nicolasmagalhaes
Copy link
Copy Markdown
Contributor

Adicionei os loops ao tables connector :foward, :backward e :yoyo como parametro no TablesConnector e o parametro padrao é :none que nao realiza nenhum tipo de loop

adding 3 loop types for connector :foward :backward :yoyo
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 2, 2020

Codecov Report

❌ Patch coverage is 43.75000% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.54%. Comparing base (ab85f41) to head (cc6a8ac).
⚠️ Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
src/connector.jl 43.75% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   32.06%   34.54%   +2.48%     
==========================================
  Files           8        8              
  Lines         131      165      +34     
==========================================
+ Hits           42       57      +15     
- Misses         89      108      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nicolasmagalhaes nicolasmagalhaes linked an issue Sep 2, 2020 that may be closed by this pull request
@nicolasmagalhaes nicolasmagalhaes added enhancement New feature or request good first issue Good for newcomers labels Sep 2, 2020
@Conradox
Copy link
Copy Markdown
Contributor

Conradox commented Sep 2, 2020

Posso estar enganado, mas acho que um melhor jeito de implementar isso seria a partir do uso do multiple dispatch oferecido pela linguagem, deixando para o interpretador a tarefa de cambiar entre as rotinas de acordo com o tipo de tabela usada na função EasySteam.next.

@Conradox
Copy link
Copy Markdown
Contributor

Conradox commented Sep 2, 2020

Um fator também importante seria a adição de testes para está funcionalidade.

@nicolasmagalhaes
Copy link
Copy Markdown
Contributor Author

Um fator também importante seria a adição de testes para está funcionalidade.

sim sim os testes eu vou colocar quando o review estiver certinho

Altered the way loops are read by using multiple dispatch
@nicolasmagalhaes
Copy link
Copy Markdown
Contributor Author

modifiquei para usar o Multiple Dispatch

@nicolasmagalhaes nicolasmagalhaes changed the title adding 3 loop types for connector :foward :backward :yoyo adding 3 loop types for connector Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possibilidade de Loop no conector TablesConector

2 participants