-
Notifications
You must be signed in to change notification settings - Fork 83
Add CI check for incorrect image filenames in new or modified .md files #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dspinellis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the swift response. Please handle the review comments. Don't be discouraged by them: this is standard practice in software development; see them as a learning opportunity.
|
Thank you for the reviews. I did all the changes you suggested, please let me know if more changes need to be done or if you want me to rebase. |
dspinellis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Only one small change. Please rebase for merge.
9b21872 to
9ebde1c
Compare
|
Is there a problem with the commit 9ebde1c ? It appears to be in the correct branch (img-check) for this PR. |
Added an img-check.sh script that verifies whether the filename and extension declared for an image inside any new or modified .md file match an existing file with the same name and extension in content/images.
Also, I updated update.yml so that the GitHub Actions workflow runs this script during CI.
Let me know if any changes or improvements are needed.