Skip to content

Handle embedding fallback dimension drift#29

Merged
AVIDS2 merged 2 commits intoAVIDS2:mainfrom
RaviTharuma:fix/embedding-fallback-dimension-drift
Mar 28, 2026
Merged

Handle embedding fallback dimension drift#29
AVIDS2 merged 2 commits intoAVIDS2:mainfrom
RaviTharuma:fix/embedding-fallback-dimension-drift

Conversation

@RaviTharuma
Copy link
Copy Markdown
Contributor

Summary

  • track active vector dimensions and avoid writing incompatible fallback embeddings into an existing index
  • degrade semantic search to fulltext when runtime provider fallback changes embedding dimensions
  • add an HTTP MCP regression that reproduces quota-triggered API fallback without breaking session search

Test Plan

  • bun run test -- tests/embedding/provider.test.ts tests/memory/vector-stability.test.ts tests/search/orama-store-semantic.test.ts tests/integration/serve-http.test.ts tests/integration/high-risk-fixes.test.ts tests/integration/http-embedding-fallback.test.ts

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Copy link
Copy Markdown
Owner

@AVIDS2 AVIDS2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this one manually. The runtime fallback + dimension-drift handling is solving a real correctness issue in the current main branch, and the approach is coherent across provider init, observation writes/backfill, reindex, and search fallback. The regression coverage is also pointed at the right failure modes. Approving and happy to merge this as-is.

@AVIDS2 AVIDS2 merged commit c67b2a6 into AVIDS2:main Mar 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants