Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d2c62ae393
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let baseUrl = getLLMBaseUrl('https://api.openai.com/v1').replace(/\/+$/, ''); | ||
| if (!baseUrl.endsWith('/v1')) baseUrl += '/v1'; | ||
| const model = getLLMModel('gpt-4o'); | ||
|
|
||
| const response = await fetch(`${baseUrl}/chat/completions`, { |
There was a problem hiding this comment.
Route vision calls by configured LLM provider
isLLMEnabled() allows this path when the runtime is configured for non-OpenAI providers, but callVisionLLM hardcodes OpenAI defaults (https://api.openai.com/v1, gpt-4o) and always posts to /chat/completions. In environments that auto-detect anthropic from ANTHROPIC_API_KEY, image ingestion will consistently fail against the wrong endpoint/model even though LLM mode is reported as enabled. This should use provider-aware config/routing (or the existing provider abstraction) so the request format matches the active provider.
Useful? React with 👍 / 👎.
|
Useful feature direction, but I see two blockers before merge.
I think the implementation needs to either:
|
Summary
Adds an
memorix_ingest_imageMCP tool that describes images using a Vision LLM and stores the description as a memorix observation.What's included
src/multimodal/image-loader.ts— Vision LLM client with:src/server.ts— MCP tool registration (memorix_ingest_image)tests/multimodal/image-loader.test.ts— 7 tests covering:Design decisions
callLLMfromsrc/llm/provider.ts) — no new API configuration needed.discoveryobservation type with image metadata in facts.fsfor file reading, existing LLM infrastructure for vision.Tests