Fix :TCB Payment Notification overwritten to Duplicate after concurrent IPN processing#22
Merged
av-dev2 merged 1 commit intoAakvatech-Limited:developfrom Apr 20, 2026
Merged
Conversation
LISACORNEL
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When TCB fires the same IPN multiple times simultaneously, the MySQL named lock serializes the workers correctly — but the late workers, after waking from the lock, would call _finalize("Duplicate", payment_entry="", sales_order="") on the same notification row that the winning worker had already marked Processed. This blanked the payment_entry and sales_order links on the record.
Fix: before calling _finalize("Duplicate", ...), check the current status of the notification row. If it is already Processed, skip the finalize — the winning worker's data is left intact.